Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Changes to ruleset validation output #3070

Merged
merged 1 commit into from
Dec 17, 2015

Conversation

fuglede
Copy link
Contributor

@fuglede fuglede commented Oct 14, 2015

This achieves a couple of different things:

  • Previously, when some rulesets contained errors, xmllint would be run twice when running it only once was sufficient. This thus saves a fair amount of time.
  • Previously, the end of the script would never actually be executed since xmllint would break it. In particular, the obtained exit status might not have been the expected one.
  • Echo errors to stderr instead of stdout.
  • Most importantly: Give some additional output when validation failure is due to one of the two most common ruleset errors, where the existing error output was not particularly helpful.

This achieves a couple of different things:
- Previously, when some rulesets contained errors, xmllint would be run twice when running it only once was sufficient. This thus saves a fair amount of time.
- Previously, the end of the script would never actually be executed since xmllint would break it.
- Echo errors to stderr instead of stdout,
- Most importantly: Give some additional output when validation failure is due to one of the two most common ruleset errors, where the existing error output was not particularly helpful.
@semenko
Copy link
Contributor

semenko commented Dec 17, 2015

Nice work -- thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants