Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

WDR: add wdr4 and www1 subdomains #6738

Merged
merged 1 commit into from
Feb 11, 2017
Merged

WDR: add wdr4 and www1 subdomains #6738

merged 1 commit into from
Feb 11, 2017

Conversation

numismatika
Copy link
Contributor

rest of the hosts from the SAN of the main certificate are omitted for now
There are small mixed content warnings but as far as i can tell the site doesn't break with the missing css.
Videos seem to work fine too.

@J0WI
Copy link
Contributor

J0WI commented Sep 4, 2016

Could you also search for subdomains?

@numismatika
Copy link
Contributor Author

There are a lot of domains in the cert for the mainpage, will take a while to see if they are even used on the web.

@J0WI
Copy link
Contributor

J0WI commented Sep 8, 2016

You can use Google to search for subdomains, even those that have no or a different cert.

@J0WI
Copy link
Contributor

J0WI commented Sep 20, 2016

Does this also address #2577 and #4227?

J0WI
J0WI reviewed Sep 20, 2016
View reviewed changes
src/chrome/content/rules/Wdr.de.xml

¹ Redirect to HTTP
Non-resolvable host:
- static.freundeskreis.einslive.de
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a host is not resolvable (=> does not exist) you don't need to list it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is part of the SAN part of the certificate for www.wdr.de so for the sake of completeness i noted that

J0WI
J0WI reviewed Sep 20, 2016
View reviewed changes
src/chrome/content/rules/Wdr.de.xml
Non-resolvable host:
- static.freundeskreis.einslive.de

Redirect to plain on:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plain is not accurate, please use 'http' or 'plain http'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be changed

@numismatika
Copy link
Contributor Author

#2577 seems fine, videos on the sportschau page play. The live-stream placeholder loop is fine too.
Haven't found a real livestream yet for testing.
#4227 still is an issue. CSS&JS are blocked as mixed-content and FF ignores our rewrite (open FF bug)

@J0WI
Copy link
Contributor

J0WI commented Sep 21, 2016

#4227 still is an issue. CSS&JS are blocked as mixed-content and FF ignores our rewrite (open FF bug)

So this rule needs either exclusions or spitted into a platform="mixedcontent" part.

WDR:
8e5a5c5 
- add wdr3 and www1 subdomains
- add more domains from the SAN
- add more subdomains
- sort target hosts alphabetically
- comment all hosts that redirect to plain or time out
- mark as mixed-content
@numismatika
Copy link
Contributor Author

numismatika commented Jan 1, 2017 •
edited
Loading

added platform="mixedcontent" to finally get this merged.
WDR takes too much time and not many things on the page are broken

@J0WI
Copy link
Contributor

J0WI commented Feb 11, 2017

trigger Travis again

@J0WI J0WI closed this Feb 11, 2017
@J0WI J0WI reopened this Feb 11, 2017
@J0WI J0WI merged commit 90f9b99 into EFForg:master Feb 11, 2017
@numismatika numismatika deleted the wdr1 branch February 14, 2017 07:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@J0WI J0WI J0WI left review comments

Assignees
No one assigned
Labels
ruleset-enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@numismatika @J0WI