Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First event is always stripped #9

Open
pevans-gfz opened this issue Jul 5, 2017 · 0 comments
Open

First event is always stripped #9

pevans-gfz opened this issue Jul 5, 2017 · 0 comments

Comments

@pevans-gfz
Copy link
Contributor

This seems to be because in event.py, line 1141, all lines with a '#' are ignored:

            if first.startswith('#'):
                # Comment line, so ignore it

However, in line 2623, the code basically removes another line again:

    myallrow[0] = "#"+myallrow[0]

    my_row_for_send =''

    # rebuild the resultset
    for item in myallrow:
        if(item):
            if(item[0]=="#"):
                continue

This results in two lines being ignored instead of just one and thus the first event not being displayed in the result page. I suggest to comment out

   myallrow[0] = "#"+myallrow[0] 

However, this might break compatibility with other fdsnws implementations, which don't have a hash tag in the first line of their respective output. As far as I know, this is not a requirement, as the CSV output is not standardised.

Reported by someone @ ETH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant