Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running git-clerk on a sub-path #79

Closed
2 tasks done
silvester-pari opened this issue Feb 7, 2025 · 0 comments · Fixed by #80
Closed
2 tasks done

Running git-clerk on a sub-path #79

silvester-pari opened this issue Feb 7, 2025 · 0 comments · Fixed by #80

Comments

@silvester-pari
Copy link
Collaborator

silvester-pari commented Feb 7, 2025

There are currently two issues preventing git-clerk to run on a sub-path (e.g. https://mywebsite.com/git-clerk/):

  • base path: the built app has base path of / and therefore the assets and the config are not found -> is there a way to set base path on runtime? Or do we need to build a docker image for each deployment?
  • since the PR number etc. are taken from the route (e.g. /${session.number}) the navigation/API calls do not work -> would it maybe be better to use query params for this? or filter out the base path from the routs...
@silvester-pari silvester-pari linked a pull request Feb 10, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant