Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't compile without W3_IC4 defined #32

Open
anton-seaice opened this issue Dec 9, 2024 · 0 comments · May be fixed by #33
Open

Doesn't compile without W3_IC4 defined #32

anton-seaice opened this issue Dec 9, 2024 · 0 comments · May be fixed by #33
Labels
bug Something isn't working

Comments

@anton-seaice
Copy link

Describe the bug
When the W3_IC4_NUMERICS macro definition was added, this prevents building when not wanting to build with W3_IC4.

At these lines :

WW3/model/src/w3srcemd.F90

Lines 2091 to 2093 in 1c11fc1

#ifndef W3_IC4_NUMERICS
CALL W3SIC4 ( SPEC,DEPTH, CG1, IX, IY, VSIC, VDIC )
#endif

when neither W3_IC4 nor W3_IC4_NUMERICS are defined, it tries to call W3SIC4, which is incorrect, as W3_IC4 is not defined. It should only call W3SIC4 when WC_IC4 is defined and W3_IC4_NUMERICS is not defined.

There is the same issue at this line

WW3/model/src/w3srcemd.F90

Lines 2122 to 2124 in 1c11fc1

#ifndef W3_IC4_NUMERICS
ATT=EXP(ICE*VDIC(IS)*DTG)
#endif

To Reproduce
Build without W3_IC4 set

Expected behavior
Should build & allow for attenuation schemes other than IC4

Screenshots

Additional context
Ill raise a PR, I have written this very poorly!

ping @dabail10

@anton-seaice anton-seaice added the bug Something isn't working label Dec 9, 2024
@anton-seaice anton-seaice linked a pull request Dec 9, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant