Replies: 5 comments 13 replies
-
|
which version of pioarduino? |
Beta Was this translation helpful? Give feedback.
-
|
1.0.6 |
Beta Was this translation helpful? Give feedback.
-
|
I am converting that to a discussion since there is no issue here but several problems in the code. |
Beta Was this translation helpful? Give feedback.
-
static AsyncMiddlewareFunction digestAuth([](AsyncWebServerRequest *request,
ArMiddlewareNext next) {
Serial.println("digestAuth");
AsyncWebServerResponse *response = request->beginResponse(401);What happens to the response pointer if you go in the else clause ? Memory leak right ? if (!request->hasHeader("Authorization")) {
response->addHeader("Access-Control-Allow-Origin", "*");
static AsyncAuthorizationMiddleware authz([](AsyncWebServerRequest *request) {
Serial.println("authz");
String sessionToken = verifyDigest(request);
if (sessionToken != "") {
Serial.println("testAuth_ok");
request->getResponse()->addHeader("X-Session-Token", sessionToken);How to you know that you have a response already set ? request->getResponse() is NULL by default... it seems to me that you are trying to reinvent the wheel but with lots of bugs included. |
Beta Was this translation helpful? Give feedback.
-
|
Also, you are mis-using the
So the code that you are doing :
Has nothing to do in an authorisation module. |
Beta Was this translation helpful? Give feedback.
-
yes it will be corrected
I hadn't seen it but it's already integrated :)
I wanted to make an authentication digest for the site, based on the “auth.ino” example.
|
Beta Was this translation helpful? Give feedback.
-
thanks for the information. |
Beta Was this translation helpful? Give feedback.
-
|
what would be a good situation to use request->getResponse()->? |
Beta Was this translation helpful? Give feedback.
-
|
The CORS middleware is a good use case for |
Beta Was this translation helpful? Give feedback.
-
|
thanks for the help, it's still a work in progress i haven't corrected all the errors yet. |
Beta Was this translation helpful? Give feedback.
-
Middleware are available in Psychic in the v2 branch (I am also a collaborator of this project but do not work on it anymore). I implemented middleware support in psychic, but the way psychic works with esp-idf behind, it is not possible to fully implement middleware support. Only ESPAsycnWebServer has a complete middleware support. |
Beta Was this translation helpful? Give feedback.
-
|
I had a question about the request body. Why, unlike physhic, to simplify is there no request->body function? |
Beta Was this translation helpful? Give feedback.
-
|
Because this is async and the callback to parse the body is called as data arrives and calls the user callback. This allow for better use of memory and eventually streaming data (to a file for exemple). Psychic is more memory hungry and parses then accumulate in memory. If you have a big request with a lof of data sent, more than the free heap, it will fail. |
Beta Was this translation helpful? Give feedback.
-
|
so every time we want to read a body we do it like a download? |
Beta Was this translation helpful? Give feedback.
-
yes! this is asynchronous: the data arrives through a callback as soon as it is made available. In the callback, there are different ways to directly use the data or accumulate it. There are many examples in the project showing how to do that. |
Beta Was this translation helpful? Give feedback.
-
|
Would it be possible later to add an example to have a basic or personalized digest (I could potentially do it if needed)? |
Beta Was this translation helpful? Give feedback.
-
You can of course send a PR to contribute an example: if you do, please copy paste an existing one and modify in order to keep the same "model". |
Beta Was this translation helpful? Give feedback.
-
|
ok I'll start as soon as I have some time |
Beta Was this translation helpful? Give feedback.
-
Platform
ESP32
IDE / Tooling
pioarduino
What happened?
i got this error while using this function.
there's not much detail on this function in the documentation, so maybe it's just me using it wrong.
Stack Trace
Minimal Reproductible Example (MRE)
here's my code:
I confirm that:
Beta Was this translation helpful? Give feedback.
All reactions