From 89a87e9d9c77a38c93e4f1632a9be7cfab06641b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Piet=20G=C3=B6mpel?= Date: Tue, 25 Feb 2025 16:18:00 +0100 Subject: [PATCH] *Enabled -Werror=switch-enum for evse_security_conversions targt * Added missing enum value conversion for CertificateValidationResult MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Piet Gömpel --- lib/staging/evse_security/CMakeLists.txt | 7 +++++++ lib/staging/evse_security/conversions.cpp | 3 ++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/staging/evse_security/CMakeLists.txt b/lib/staging/evse_security/CMakeLists.txt index d2ccc4ddb..a58ad23d3 100644 --- a/lib/staging/evse_security/CMakeLists.txt +++ b/lib/staging/evse_security/CMakeLists.txt @@ -13,6 +13,12 @@ target_include_directories(evse_security_conversions "$" ) +target_compile_options(evse_security_conversions + PRIVATE + -Wimplicit-fallthrough + -Werror=switch-enum +) + add_dependencies(evse_security_conversions generate_cpp_files) target_link_libraries(evse_security_conversions @@ -20,3 +26,4 @@ target_link_libraries(evse_security_conversions everest::evse_security everest::framework ) + diff --git a/lib/staging/evse_security/conversions.cpp b/lib/staging/evse_security/conversions.cpp index 909f98962..7bc1f098c 100644 --- a/lib/staging/evse_security/conversions.cpp +++ b/lib/staging/evse_security/conversions.cpp @@ -328,9 +328,10 @@ types::evse_security::CertificateValidationResult to_everest(evse_security::Cert return types::evse_security::CertificateValidationResult::InvalidLeafSignature; case evse_security::CertificateValidationResult::InvalidChain: return types::evse_security::CertificateValidationResult::InvalidChain; + case evse_security::CertificateValidationResult::Expired: + return types::evse_security::CertificateValidationResult::Expired; case evse_security::CertificateValidationResult::Unknown: return types::evse_security::CertificateValidationResult::Unknown; - ; default: throw std::runtime_error("Could not convert evse_security::CertificateValidationResult to " "types::evse_security::CertificateValidationResult");