Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start websocket ping timer when websocket connects #1001

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Start websocket ping timer when websocket connects #1001

merged 1 commit into from
Feb 27, 2025
+3 −1

Conversation

Pietfried
Copy link
Contributor

@Pietfried Pietfried commented Feb 27, 2025 •
edited
Loading

Describe your changes

  • Fixed issue that websocket ping timer was not started when websocket is connected.
  • Set default ping interval to 10s

Issue ticket number and link

Checklist before requesting a review

@Pietfried Pietfried merged commit dc51a49 into main Feb 27, 2025
8 checks passed
@Pietfried Pietfried deleted the bugfix/start-ws-ping-timer branch February 27, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikinggrass hikinggrass hikinggrass approved these changes

@maaikez maaikez Awaiting requested review from maaikez maaikez is a code owner

@marcemmers marcemmers Awaiting requested review from marcemmers marcemmers is a code owner

Assignees

@hikinggrass hikinggrass

Labels
include-in-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pietfried @hikinggrass