Added to all switches full coverage of cases #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AssemblyJohn
requested review from
Pietfried,
hikinggrass,
maaikez and
marcemmers
as code owners
AssemblyJohn
changed the title
|
For me, the error parameter is a bit too restrictive, because we have the message types that are not few, and it yields huge switches that have many unused values. See: https://github.com/EVerest/libocpp/pull/996/files#diff-da763790e13775835ba45ecb201db0dc9c691df39b8c4f318f1a37703c1645d6R1390 |
…nts are missing Signed-off-by: AssemblyJohn <[email protected]>
Pietfried
force-pushed
the
bugfix/switch_enum_conversion_compile_checks
branch
from
4349261 to
d41b1a7
Compare
* Switched from runtime_error or out_of_range to more specific Exceptions: EnumConversionException, StringToEnumException, EnumToStringException Signed-off-by: Piet Gömpel <[email protected]>
hikinggrass
requested changes
Feb 25, 2025
Signed-off-by: Piet Gömpel <[email protected]>
hikinggrass
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review