Regridding to larger grid results in NaNs outside of data range #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSchilperoort
requested changes
Feb 27, 2024
BSchilperoort
previously approved these changes
Feb 28, 2024
Comment on lines
+96
to
+98
| uncovered_target_grid[coord] = (coords[coord] <= data[coord].max()) & ( | ||
| coords[coord] >= data[coord].min() | ||
| ) |
There was a problem hiding this comment.
It does look a bit ugly now after formatting. You can add parenthesis to make it look better:
Suggested change
| uncovered_target_grid[coord] = (coords[coord] <= data[coord].max()) & ( | |
| coords[coord] >= data[coord].min() | |
| ) | |
| uncovered_target_grid[coord] = ( | |
| (coords[coord] <= data[coord].max()) & | |
| (coords[coord] >= data[coord].min()) | |
| ) |
There was a problem hiding this comment.
I agree with this. Your suggestion is what I originally had, but ruff switched it back after formatting. Do you think we should use our preferred format or do as ruff suggests?
There was a problem hiding this comment.
Oh odd. Well it's best to keep it formatted, despite it being a bit ugly.
Alternatively you could use the np.bitwise_and function:
uncovered_target_grid = np.bitwise_and(
coords[coord] <= data[coord].max(), coords[coord] >= data[coord].min()
)But I think this is acceptable.
| @@ -141,8 +143,9 @@ def conservative_regrid_dataarray( | |||
| coord_attrs = [data[coord].attrs for coord in data_coords] | |||
|
|
|||
| for coord in coords: | |||
| mask = ((coords[coord] <= data[coord].max()) | |||
| & (coords[coord] >= data[coord].min())) | |||
| uncovered_target_grid = (coords[coord] <= data[coord].max()) & ( | |||
There was a problem hiding this comment.
Same here (formatting)
BSchilperoort
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where regridding to larger grid did not result in NaNs at locations where there was no starting data. Uses a mask after regridding to fill along each coordinate with the NaNs.