Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses Deprecated API in ViaFabricPlus v4.0.0-SNAPSHOT (ef763be) #702

Closed
Finoway opened this issue Jan 2, 2025 · 0 comments
Closed

Uses Deprecated API in ViaFabricPlus v4.0.0-SNAPSHOT (ef763be) #702

Finoway opened this issue Jan 2, 2025 · 0 comments

Comments

@Finoway
Copy link

Finoway commented Jan 2, 2025

Hello,

I downloaded the latest version of ViaFabricPlus from GitHub, corresponding to the latest commit (v4.0.0-SNAPSHOT, commit ef763be). Upon joining a server, I noticed a warning in the console indicating that a mod is using deprecated internals of ViaFabricPlus that will be removed in future updates. The warning suggests updating the mod to use the new API introduced in version 4.0.0.

I tested this with ClientCommands 2.9.9 and observed the following stack trace:

[09:56:08] [Render thread/WARN]: A mod is using deprecated ViaFabricPlus internals which will be removed in the future.
[09:56:08] [Render thread/WARN]: Please contact the mod author to update their code to use the general API point added in 4.0.0.
[09:56:08] [Render thread/WARN]: The error below will point to the mod calling the deprecated API.
[09:56:08] [Render thread/INFO]: [STDERR]: java.lang.Exception: Stack trace
[09:56:08] [Render thread/INFO]: [STDERR]: 	at java.base/java.lang.Thread.dumpStack(Thread.java:2209)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at knot//de.florianmichael.viafabricplus.LegacyCompatBridge.warn(LegacyCompatBridge.java:45)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at knot//de.florianmichael.viafabricplus.protocoltranslator.ProtocolTranslator.getTargetVersion(ProtocolTranslator.java:38)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at knot//net.earthcomputer.clientcommands.util.MultiVersionCompat$ViaFabricPlus.getProtocolVersion(MultiVersionCompat.java:205)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at knot//net.earthcomputer.clientcommands.command.BookCommand.register(BookCommand.java:37)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at knot//net.earthcomputer.clientcommands.ClientCommands.registerCommands(ClientCommands.java:120)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at knot//net.fabricmc.fabric.api.client.command.v2.ClientCommandRegistrationCallback.lambda$static$0(ClientCommandRegistrationCallback.java:36)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at knot//net.minecraft.class_634.handler$zec000$fabric-command-api-v2$onGameJoin(class_634.java:6675)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at knot//net.minecraft.class_634.method_11120(class_634.java:507)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at knot//net.minecraft.class_2678.method_11567(class_2678.java:69)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at knot//net.minecraft.class_2678.method_65081(class_2678.java:17)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at knot//net.minecraft.class_2600.method_11072(class_2600.java:27)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at knot//net.minecraft.class_1255.method_18859(class_1255.java:164)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at knot//net.minecraft.class_4093.method_18859(class_4093.java:23)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at knot//net.minecraft.class_1255.method_16075(class_1255.java:138)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at knot//net.minecraft.class_1255.method_5383(class_1255.java:123)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at knot//net.minecraft.class_310.method_1523(class_310.java:1296)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at knot//net.minecraft.class_310.method_1514(class_310.java:922)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at knot//net.minecraft.client.main.Main.main(Main.java:267)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:105)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129)
[09:56:08] [Render thread/INFO]: [STDERR]: 	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70)
[09:56:08] [Render thread/WARN]: ===========================================```
@Finoway Finoway changed the title Compatibility Issue with ViaFabricPlus v4.0.0-SNAPSHOT (ef763be) and ClientCommands 2.9.9 Uses Deprecated API in ViaFabricPlus v4.0.0-SNAPSHOT (ef763be) Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant