Wide/Ultra Wide screen shaking issue

[BlisterB]

In the game "A tale of Yu - Onsen RPG":

• https://www.rpg-maker.fr/jeux-1067-onsen-rpg-a-tale-of-yu.html
• Click on the "Telecharger" button on the bottom center of the page

When enabling Wide Screen or Ultra Wide Screen in options (F1 > Video), the screen is extremely shaky, or completely broken.
Both on windowed and full screen mode.

The video below just capture a fraction of the bug (too much shaky to be recorded).

Enregistrement.2025-01-18.162513.mp4

[BlisterB]

As you can see here, things are drawn outside of the border of the map.

[BlisterB]

Here, the map is not centered

[BlisterB]

All these issues are present in the continuous build. But absent in a build from January 2024, so it's likely a regression introduced in the meantime.

[Ghabry]

Thanks for the report. That looks strange.
Whether this will be fixed before 0.8.1 depends on how hard this will be to bisect (and fix)

[BlisterB]

After some testings, it concerns every games, when the map is shorter than the screen.

[Ghabry]

This bug was actually already reported on January 12 via Mail with Video attached on Android. I concluded that its a bug with the video driver (it looked like a Vsync bug I had on WiiU) and they responded that altering the frame limit fixed it...

Looking at the logfile the Player was set to widescreen.

---

This is bad. My first guess was a fix for Beloved Rapture when the width/height is not a multiple of the tile size and I was right:

e7767ff

The bug is moving from std::min/max to std::clamp which doesn't work here because map_width - screen_width can be negative, making it an invalid upper bound (smaller than the lower bound).

(Currently testing this on Windows where it directly triggers an assert in the debugger. On Linux it silently accepts the wrong arguments, awesome)

[BlisterB]

I've quickly tested the build from #3334 and it seems to solve the issue. 👍
I will stick with this build to detect potential problems. 👍