Remove the need for pkgconfig in cmake config #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add logic to generate the needed paths manually for autotools Import prefix handling is based on CMakePackageConfigHelpers
fdelapena
approved these changes
Aug 27, 2021
Comment on lines
+2
to
3
| # liblcf-config | ||
| # ------- |
There was a problem hiding this comment.
Nit: the underlined text does not match the new length from above
Suggested change
| # liblcf-config | |
| # ------- | |
| # liblcf-config | |
| # ------------- |
carstene1ns
force-pushed
the
bugfix/cmake-no-pkgconfig
branch
from
07467a4 to
934c0d4
Compare
|
confirmed working on macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fun fact: most of the autotools hackery is only needed for distributions like debian and mageia (hello #341), that put stuff in custom directories.