SavePicture: Add chunks for Flip and Blend Mode #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdelapena
approved these changes
Sep 1, 2021
|
IMO the flip mode should be an enum: |
Flip & Blend: Maniac Patch uses the upper bits of finish_bot_trans for this which is ugly Fixed Angle: This is a new value for the effect parameter. Had to put this in the normal enums.csv due to generator limitations
|
reduced to one Flip chunk and added a new enum for the "effect": This is for the fixed angle (instead of rotating) |
carstene1ns
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to KeyInput where the usage of the upper bits made sense here it is far too ugly to handle this way:
Maniac Patch uses the upper bits of finish_bot_trans for this which is imo very very ugly.
Instead I add here 3 new chunks, so savegames will be incompatible.
The Blend Mode is an integer to get more flexibility compared to Multiply/Add/Overlay of Maniacs.