Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove refusal of RS_, GB_, and UBA genome IDs #131

Closed
donovan-h-parks opened this issue Jun 4, 2019 · 3 comments · Fixed by #237
Closed

Remove refusal of RS_, GB_, and UBA genome IDs #131

donovan-h-parks opened this issue Jun 4, 2019 · 3 comments · Fixed by #237
Labels
enhancement Proposed feature or change to GTDB-Tk. next version Upcoming feature/fix in staging branch.

Comments

@donovan-h-parks
Copy link
Collaborator

Currently, the GTDB-Tk will not accept user genomes that start with RS_, GB_, or UBA. This is to ensure that user genomes have unique names relative to the GTDB-Tk reference genomes. It would be better if we just explicitly checked for a conflict, but otherwise accepted any user genome IDs. It is possible and reasonable, that users will have genomes they have called UBAxxx since this is the common ID for these genomes. This approach will also be problematic if we move to a Gxxx type reference ID system.

@donovan-h-parks donovan-h-parks added the enhancement Proposed feature or change to GTDB-Tk. label Jun 4, 2019
@aaronmussig
Copy link
Member

A possible workaround to this would be appending a GTDB-Tk prefix to all reference genomes (e.g. GTDBTKREF_UBA1234, GTDBTKREF_Gxxx) and remove this prefix when outputting results.

Alternatively, if a user genome is found to have a non-unique ID we could ignore it in the pipeline and output a warning.

@donovan-h-parks
Copy link
Collaborator Author

My preference would be to create a list of reference GTDB-Tk IDs and check for conflicts with the User genomes. Any conflicts can be reported to the user and the program terminated (i.e. this is an unresolvable error the user must address).

@pchaumeil pchaumeil added this to the 1.1.0 milestone Dec 11, 2019
@pchaumeil
Copy link
Collaborator

Implemented in ec31c86

@pchaumeil pchaumeil modified the milestones: 1.1.0, 1.0.3 Feb 25, 2020
@pchaumeil pchaumeil added the next version Upcoming feature/fix in staging branch. label Feb 25, 2020
@aaronmussig aaronmussig linked a pull request Apr 8, 2020 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Proposed feature or change to GTDB-Tk. next version Upcoming feature/fix in staging branch.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants