Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Fixes Responsiveness break on internal pages of documentation page #3068

Merged
merged 3 commits into from
Jan 14, 2023

Conversation

arpitghura
Copy link
Contributor

@arpitghura arpitghura commented Jan 10, 2023

Fixes Issue #2857

fixes #2857

Changes proposed

  • add classes to url for its responsiveness
  • make images responsive

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

image

Note to reviewers

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added the small Pull request with less than 10 changed lines label Jan 10, 2023
@eddiejaoude
Copy link
Member

Looks good 👍 any reason why it is in draft?

@arpitghura arpitghura marked this pull request as ready for review January 13, 2023 23:02
@arpitghura
Copy link
Contributor Author

Looks good 👍 any reason why it is in draft?

I am looking to another issue which I am facing on my system and that is un-responsive images, I have shared some screenshot regarding it in #2857. Have a look at it.

@eddiejaoude
Copy link
Member

I am looking to another issue which I am facing on my system and that is un-responsive images, I have shared some screenshot regarding it in #2857. Have a look at it.

But I don't think this is related to this pull request?

@eddiejaoude eddiejaoude merged commit 3cbf8e3 into EddieHubCommunity:main Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
small Pull request with less than 10 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Responsiveness breaks on Internal pages of doc page.
2 participants