This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
feat: api handle redirects (#3246) #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
github-actions
bot
added
large
gptkrsh
reviewed
Jan 15, 2023
| } | ||
|
|
||
| if (!data.links.find((link) => link.url === url)) { | ||
| console.log(`ERROR link ${url} not found for username ${username}`); |
There was a problem hiding this comment.
We also use this endpoint for socials 😅
There was a problem hiding this comment.
Good spot 👍
(oops I hit resolved instead of comment, time for me to take a break)
There was a problem hiding this comment.
I fixed with a && condition, please can you re-review
github-actions
bot
added
the
✍ chore: profile
eddiejaoude
force-pushed
the
krshkun/api-link-redirect-recorders
branch
from
a75cf46 to
d0c665c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: api handle redirects
broken code
comment out tests
tests
tests
remove
directory for username
directory for links
api redirect
changes
Restore package-lock.json
Fixes Issue
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers