This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
medium
Pull request with changed lines between 10 and 30
waiting-for-reviewers
labels
Jul 3, 2023
eddiejaoude
reviewed
Jul 3, 2023
dan-mba
reviewed
Jul 3, 2023
eddiejaoude
suggested changes
Jul 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even model schema needs updating to save the color
- I left an inline comment
eddiejaoude
reviewed
Jul 10, 2023
eddiejaoude
suggested changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Please also add the following:
- I added inline comments
- model has validation but this is not checked on the API https://github.com/EddieHubCommunity/LinkFree/blob/main/pages/api/account/manage/event/%5B%5B...data%5D%5D.js#L85
okay, done. |
eddiejaoude
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
- the color is not displayed on the main events page, this could be due to the grouping, but I think the PR adds value already as it has customisation for the users profile events
- further improvements can come in another Issue and PR
akkshitgupta
pushed a commit
to akkshitgupta/BioDrop
that referenced
this pull request
Jul 13, 2023
* event css issue fixed * event model schema updated * Update UserEvents.js * Update UserEvents.js * added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
issue linked
Pull Request has issue linked
medium
Pull request with changed lines between 10 and 30
waiting-for-reviewers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Closes #7840 #7642
Changes proposed
Before:-
Now:-
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers