Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix: Event CSS issue fixed #7942

Merged
merged 7 commits into from
Jul 12, 2023
Merged

Conversation

anikdhabal
Copy link
Contributor

@anikdhabal anikdhabal commented Jul 3, 2023

Fixes Issue

Closes #7840 #7642

Changes proposed

Before:-
Screenshot 2023-07-03 100053
Screenshot 2023-07-03 100037

Now:-
Screenshot 2023-07-05 133845
Screenshot 2023-07-05 133902

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@github-actions github-actions bot added medium Pull request with changed lines between 10 and 30 waiting-for-reviewers labels Jul 3, 2023
tailwind.config.js Outdated Show resolved Hide resolved
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even model schema needs updating to save the color - I left an inline comment

@SaraJaoude SaraJaoude added the issue linked Pull Request has issue linked label Jul 4, 2023
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Please also add the following:

@anikdhabal
Copy link
Contributor Author

Looks good 👍

Please also add the following:

okay, done.

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

  • the color is not displayed on the main events page, this could be due to the grouping, but I think the PR adds value already as it has customisation for the users profile events
  • further improvements can come in another Issue and PR

@eddiejaoude eddiejaoude merged commit 8648bbe into EddieHubCommunity:main Jul 12, 2023
akkshitgupta pushed a commit to akkshitgupta/BioDrop that referenced this pull request Jul 13, 2023
* event css issue fixed

* event model schema updated

* Update UserEvents.js

* Update UserEvents.js

* added
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue linked Pull Request has issue linked medium Pull request with changed lines between 10 and 30 waiting-for-reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Events CSS issue
4 participants