Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low contrast of colored texts from dayfox #282

Closed
oxalica opened this issue Jan 1, 2023 · 5 comments · Fixed by #285
Closed

Low contrast of colored texts from dayfox #282

oxalica opened this issue Jan 1, 2023 · 5 comments · Fixed by #285
Assignees
Labels
bug Something isn't working palette Change related color values of palette

Comments

@oxalica
Copy link
Contributor

oxalica commented Jan 1, 2023

Description

dayfox's colored texts are much harder to read than nightfox.
All primary colors from dayfox except black failed the contrast requirement of WCAG AA level.
Example of red v.s. background: https://webaim.org/resources/contrastchecker/?fcolor=B95D76&bcolor=EAEAEA

Behavior

Expected behavior
Colored texts using dayfox should be as easy to read as nightfox.

Screenshots
README's picture seems convincing enough.

@oxalica oxalica added the bug Something isn't working label Jan 1, 2023
@EdenEast
Copy link
Owner

EdenEast commented Jan 3, 2023

I do agree that dayfox does need some updates to make it more contrasting. I will try and do a pass over it to make it more contrasting.

@EdenEast EdenEast self-assigned this Jan 3, 2023
@EdenEast EdenEast added the palette Change related color values of palette label Jan 4, 2023
@oxalica
Copy link
Contributor Author

oxalica commented Jan 4, 2023

BTW, there are also colors in other themes having low contrasts, including red v.s. background and comment v.s. background in nightfox.

@D00mch
Copy link

D00mch commented Jan 5, 2023

I preferred the previous "dayfox". Please do not update "dawnfox":) I'm now using it.

@EdenEast
Copy link
Owner

EdenEast commented Jan 5, 2023

For those that want to use the old dayfox you can use tag v2.1.0.

@EdenEast
Copy link
Owner

EdenEast commented Jan 6, 2023

For those that want to use the old dayfox check this comment on how to override it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working palette Change related color values of palette
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants