Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Comment highlights do not work with newer versions of nvim-treesitter #410

Closed
msc94 opened this issue Jan 24, 2024 · 2 comments
Closed
Labels
bug Something isn't working needs:response

Comments

@msc94
Copy link

msc94 commented Jan 24, 2024

Neovim version (nvim -v)

0.9

Operating system/version

Linux

Describe the bug

nvim-treesitter seem to have updated their capture groups for todo, wip, notes, etc in comments here: nvim-treesitter/nvim-treesitter@1ae9b0e

I fixed it locally with

-- TODO: Remove when colorscheme has been updated
vim.api.nvim_set_hl(0, "@comment.todo", { link = "@text.todo" })
vim.api.nvim_set_hl(0, "@comment.note", { link = "@text.note" })
vim.api.nvim_set_hl(0, "@comment.warning", { link = "@text.warning" })
vim.api.nvim_set_hl(0, "@comment.error", { link = "@text.error" })

but it would be cool if it was in the colorscheme again.
I would make a PR, but don't really know if you want to keep the old capture groups as well for backwards compatibility?

Steps To Reproduce

  1. Update nvim-treesitter to newest version
  2. Install treesitter comments parser
  3. See if TODO is highlighted in comments

Expected Behavior

TODO highlighted

Repro

No response

@msc94 msc94 added the bug Something isn't working label Jan 24, 2024
@EdenEast
Copy link
Owner

What commit are you on as this has been updated in #404.

@msc94
Copy link
Author

msc94 commented Jan 25, 2024

I'm sorry, I was having mismatched versions then.
I didn't see this commit when I was analyzing the issue. Thank you for the hint.

And, thanks for your work, amazing colorscheme!

@msc94 msc94 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs:response
Projects
None yet
Development

No branches or pull requests

2 participants