From 7a11771954a8d85ad037fee5e9e7c8aa57807177 Mon Sep 17 00:00:00 2001
From: Raphael Coeffic <raphael.coeffic@frafos.com>
Date: Thu, 27 Oct 2022 10:16:32 +0200
Subject: [PATCH] Conversions tests for QX7 only on QX7

---
 radio/src/tests/conversions.cpp | 22 +++++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)

diff --git a/radio/src/tests/conversions.cpp b/radio/src/tests/conversions.cpp
index 622a9a0b7e8..d19a94b9dbb 100644
--- a/radio/src/tests/conversions.cpp
+++ b/radio/src/tests/conversions.cpp
@@ -217,7 +217,19 @@ TEST(Conversions, ConversionXLiteFrom23)
 }
 #endif
 
-#if defined(PCBX7) && (STORAGE_CONVERSIONS <= 219)
+#if defined(RADIO_X7) && (STORAGE_CONVERSIONS <= 219)
+
+static swarnstate_t get_configured_switch_warn_mask()
+{
+  swarnstate_t mask = 0;
+  for (uint8_t i=0; i<NUM_SWITCHES; i++) {
+    if (SWITCH_CONFIG(i) != 0)
+      mask |= 7 << (3 * i);
+  }
+
+  return mask;
+}
+
 TEST(Conversions, ConversionX7From23)
 {
 #if defined(SDCARD_YAML)
@@ -256,11 +268,11 @@ TEST(Conversions, ConversionX7From23)
     (0x02) |            // SA middle
     (0x01 << (3 * 1)) | // SB up
     (0x03 << (3 * 2)) | // SC down
-    (0x03 << (3 * 4));  // SF down
-
-  swarnstate_t sw_mask = (1 << (NUM_SWITCHES * 3)) - 1;
+    (0x03 << (3 * 4)) | // SF down
+    (0x01 << (3 * 5));  // SH up
   
-  // check only the "allowed switches"
+  // check only configured switches (as the code does)
+  swarnstate_t sw_mask = get_configured_switch_warn_mask();
   EXPECT_EQ(state & sw_mask, g_model.switchWarningState & sw_mask);
   
   EXPECT_STRNEQ("Test", g_model.header.name);