Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long press ENT on TLite when still in navigation mode #5398

Closed
1 task done
pfeerick opened this issue Aug 7, 2024 · 2 comments · Fixed by #5404
Closed
1 task done

Long press ENT on TLite when still in navigation mode #5398

pfeerick opened this issue Aug 7, 2024 · 2 comments · Fixed by #5404
Labels
B&W Related generally to black and white LCD radios bug 🪲 Something isn't working

Comments

@pfeerick
Copy link
Member

pfeerick commented Aug 7, 2024

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

When using the left and right buttons to step through the model setup menus (not radio setup, this does not appear to suffer from this), and the cursor is hilighting the screen count, long press of the top left (ENT) key will carry out long press behaviour. This could be considered a shortcut for the top line, if the line the long press behaviour was triggered on didn't follow the last line you long pressed.

This is likely a X9 specific navigation/UI bug. It seems to keep the index of the last row/line long pressed (interacted with?) when changing screens, and only update if you scroll up/down after changing screens.

Expected Behavior

For the long press to be ignored since it's not valid here.

Steps To Reproduce

  1. Long press MDL
  2. Short press MDL repeatedly until you get to the MIXES screen
  3. Use Down to go down 2-3 lines
  4. Long Press ENT, then press RTN to close popup (choosing a menu entry is not necessary, only bringing up menu)
  5. Press RTN, use SYS to go back to INPUTS
  6. Long ENT while highlight still on top right page count. Chose Edit. Note that the input line being edited is not the top line, but the equivalent/same line count down from the MIXES screen.

Version

Nightly (Please give date/commit below)

Transmitter

Jumper T-Lite

Operating System (OS)

No response

OS Version

No response

Anything else?

This is not a new bug, I was able to repo this on 2.10.3 and 2.9.4 simulators as well as tripping over it in #5386

@pfeerick pfeerick added bug 🪲 Something isn't working B&W Related generally to black and white LCD radios labels Aug 7, 2024
@philmoz
Copy link
Collaborator

philmoz commented Aug 7, 2024

I think the long press should be ignored if the cursor is on the top line.

@pfeerick
Copy link
Member Author

pfeerick commented Aug 7, 2024

Agreed... hence the bug report and

This could be considered a shortcut for the top line, if the line the long press behaviour was triggered on didn't follow the last line you long pressed.

This isn't the case, so even that doesn't apply 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B&W Related generally to black and white LCD radios bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants