fix: use javascript_include_tag in vite_client_tag #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to inherit all the features of the `javascript_include_tag` it should be used within `vite_client_tag`. Otherwise you won't get CSP support and all other built-in features.
|
Looks good, thanks! |
ElMassimo
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
In order to inherit all the features of the
javascript_include_tagit should be used withinvite_client_tag. Otherwise you won't get CSP support and all other built-in features.Background 📜
You won't be able to work with
vite_client_tagin a CSP environment without this change.The Fix 🔨
Use
javascript_include_taginstead oftag.script