fix: ensure rails app is initialized before inferring config #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElMassimo
added a commit
that referenced
this pull request
Aug 12, 2022
Ensure that when using vite_rails the parent Rails app is initialized before the config is resolved. This ensures that it's safe to access Rails config values in config/vite.rb, and that settings like asset_host are always detected.
ElMassimo
added a commit
that referenced
this pull request
Aug 12, 2022
Ensure that when using vite_rails the parent Rails app is initialized before the config is resolved. This ensures that it's safe to access Rails config values in config/vite.rb, and that settings like asset_host are always detected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request ensures that when using
vite_railsthe parent Rails app is initialized before the config is resolved.This ensures that it's safe to access Rails config values in
config/vite.rb, and that settings likeasset_hostare always detected.Background 📜
This pull request is a follow-up to:
The attempt to fix it only solved some situations, but does not work in all cases.
The Fix 🔨
Explicitly requiring the application and initializing it ensures the config is available before running a build