feat: allow javascript_include_tag options to vite_client_tag #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhoy
changed the title
This allows passing options such as `nonce`, which some browsers require if CSP is set (Firefox). Co-authored-by: Wil Hall <[email protected]>
mjhoy
force-pushed
the
allow-options-to-vite-client-tag
branch
from
53b9573 to
2c68d0a
Compare
|
Thanks Mikey and Wil! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
This allows passing options such as
nonce, which some browsers require if CSP is set (Firefox).Background 📜
With CSP set in Rails, Firefox would fail to load the vite client tag without a
nonceset.The Fix 🔨
vite_client_tagnow accepts anoptionshash that is passed tojavascript_include_tag, much likevite_javascript_tag.Co-authored-by: Wil Hall [email protected]