Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: shouldUpdateHeight should be true when maxHeight is set #10034

Merged
merged 1 commit into from
Mar 6, 2018

Conversation

Leopoldthecoder
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

@furybean
Fixes #10009

  • Make sure you follow Element's contributing guide (中文 | English | Español).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@Leopoldthecoder Leopoldthecoder requested a review from furybean March 6, 2018 10:17
@hilanmiao
Copy link

but,it‘s not work in my project。element-ui version 2.2.2,vue version 2.5.16

@goforward01
Copy link

Hi, @Leopoldthecoder, Just like @hilanmiao said, it doesn't work for me either. I didn't set max-height but I set height of table to a number. the version of element-ui is 2.2.2 too. Sorry about I can't give a online demo for I couldn't visit jsFiddle(FGW). The shouldUpdateHeight doesn't change while the height of table or the body wrapper of table should be updated. May you take a look about this when you have time, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants