Message-box: fix multiple messagebox with duplicate title #10126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/message-box/src/main.vue
Outdated
| @@ -10,7 +10,7 @@ | |||
| :aria-label="title || 'dialog'" | |||
| > | |||
| <div class="el-message-box" :class="[customClass, center && 'el-message-box--center']"> | |||
| <div class="el-message-box__header" v-if="title !== undefined"> | |||
| <div class="el-message-box__header" v-if="title !== null || title !== undefined"> | |||
There was a problem hiding this comment.
title !== null || title !== undefined always returns true regardless of what title is. I think it should be title !== null here.
|
OK, changed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Fix when multiple messagebox with duplicate title, for-example, the first one has title option, but the second one hasn't, and click the first one then the second one has the first title.
[jsfiddle] (https://jsfiddle.net/maj51e8z/3/)