From 0a3f3af0d5aed78f36ea5159552cbd99d7180714 Mon Sep 17 00:00:00 2001 From: Eliah Kagan Date: Fri, 8 Nov 2024 16:43:31 -0500 Subject: [PATCH] Exclude performance test(s) from expected failures This omits tests containing `performance` (and not as part of a larger "word", not even with `_`) from being expected to fail on CI with `GIX_TEST_IGNORE_ARCHIVES=1` on Windows. Currently there is one such test listed in #1358, `gix-ref-tests::refs packed::iter::performance`. --- .github/workflows/ci.yml | 3 +-- scratchwork.ps1 | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4865e12d503..08e347c340e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -119,9 +119,8 @@ jobs: Out-String | Select-String -Pattern '(?s)```text\r?\n(.*?)```' - # FIXME: Check that the diff can fail, then filter out performance tests in Where-Object. $expected_failures = $match_info.Matches.Groups[1].Value -split "`n" | - Where-Object { $_ -match '^\s*FAIL \[' } | + Where-Object { ($_ -match '^\s*FAIL \[') -and ($_ -notmatch '\bperformance\b') } | ForEach-Object { $_ -replace '^\s*FAIL \[\s*\d+\.\d+s\]\s*', '' -replace '\s+$', '' } | Sort-Object diff --git a/scratchwork.ps1 b/scratchwork.ps1 index 89816aaa18e..5fa6c2f102f 100644 --- a/scratchwork.ps1 +++ b/scratchwork.ps1 @@ -22,9 +22,8 @@ $match_info = gh issue --repo GitoxideLabs/gitoxide view $issue --json body --jq Out-String | Select-String -Pattern '(?s)```text\r?\n(.*?)```' -# FIXME: Check that the diff can fail, then filter out performance tests in Where-Object. $expected_failures = $match_info.Matches.Groups[1].Value -split "`n" | - Where-Object { $_ -match '^\s*FAIL \[' } | + Where-Object { ($_ -match '^\s*FAIL \[') -and ($_ -notmatch '\bperformance\b') } | ForEach-Object { $_ -replace '^\s*FAIL \[\s*\d+\.\d+s\]\s*', '' -replace '\s+$', '' } | Sort-Object