feat(dashboard): Add LoadingSpinner to table #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminpaige
approved these changes
Sep 25, 2023
|
🎉 This PR is included in version 1.5.0-val.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The original purpose of this ticket was to create and display a skeleton loader while the table data loads (and when dynamic search is used). After discussing it last week after PI planning, we determined that we should discuss the skeleton loader with HCD before building it out.
This ticket locates the place where the skeleton loader would go and displays the
LoadingSpinnercomponent while the table data loads to indicate to the user that the data is loading.The follow-up ticket for the discussion with HCD is located here: https://qmacbis.atlassian.net/browse/OY2-25623
Linked Issues to Close
https://qmacbis.atlassian.net/browse/OY2-25289
Approach
In the
OsTablecomponent, we usecontext.isLoadingto show or hide the loading spinner. This is also the location where we would insert our skeleton loader component.