-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(add-breadcrumbs): Add Bread Crumbs to the Mako Web Application #162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woo! thats hot right there. love them crumbs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love that there's tests! Great job
🎉 This PR is included in version 1.5.0-val.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Purpose
This is to add a new feature to Mako. It is now an expected behaivor that the user will be able to navigate through the use of breadcrumbs when walking through SPA and Waiver creation.
Linked Issues to Close
https://qmacbis.atlassian.net/browse/OY2-25651
Approach
This is a configuration driven approach that allows for the breadcrumbs within the application to be dynamic based on the path of the url.
Assorted Notes/Considerations/Learning
This is made in a way that can be expanded upon in the future. It is however important to note that we need to keep the hierarchical approach to routing (for example '/submission/type/waiver/1915b/new') if we want to keep the dynamic nature of the breadcrumbs.