Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(add-breadcrumbs): Add Bread Crumbs to the Mako Web Application #162

Merged
merged 17 commits into from
Oct 17, 2023

Conversation

13bfrancis
Copy link
Collaborator

Purpose

This is to add a new feature to Mako. It is now an expected behaivor that the user will be able to navigate through the use of breadcrumbs when walking through SPA and Waiver creation.

Linked Issues to Close

https://qmacbis.atlassian.net/browse/OY2-25651

Approach

This is a configuration driven approach that allows for the breadcrumbs within the application to be dynamic based on the path of the url.

Assorted Notes/Considerations/Learning

This is made in a way that can be expanded upon in the future. It is however important to note that we need to keep the hierarchical approach to routing (for example '/submission/type/waiver/1915b/new') if we want to keep the dynamic nature of the breadcrumbs.

Copy link
Contributor

@mdial89f mdial89f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@benjaminpaige benjaminpaige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo! thats hot right there. love them crumbs!

Copy link

@hannasage hannasage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love that there's tests! Great job

@13bfrancis 13bfrancis merged commit d57f2df into master Oct 17, 2023
15 checks passed
@13bfrancis 13bfrancis deleted the nurse branch October 17, 2023 17:41
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants