Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(minor things): Some clean up and standardization #177

Merged
merged 8 commits into from
Oct 30, 2023
Merged

fix(minor things): Some clean up and standardization #177

merged 8 commits into from
Oct 30, 2023

Conversation

mdial89f
Copy link
Contributor

@mdial89f mdial89f commented Oct 25, 2023 •
edited
Loading

Purpose

This changeset is comprised of small things noticed over the sprint.

Linked Issues to Close

None

Approach

  • The destroy workflow was found to have improper, but functional, syntax. This was causing vs code to evaluate the file poorly and so it was difficult to read.
  • The slack username for alerts in the destroy function was made to be the same as the deploy slack notification.
  • A few adjustments to the cleanup kafka lambda function were made. These changes were made when looking into the occasional failure of the data service to destroy. The connection to rejectUnauthorized set to false is to fall in line with our other kafka connection utilities. The retry set to zero is what I hope will fix our destroy failures. I'm not sure, but I haven't been able to reproduce the error with these changes. It may very well keep occurring.
  • some lint fixes

Assorted Notes/Considerations/Learning

None

@mdial89f mdial89f merged commit 0705c3f into master Oct 30, 2023
@mdial89f mdial89f deleted the monitor branch October 30, 2023 15:06
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@13bfrancis 13bfrancis 13bfrancis approved these changes

@benjaminpaige benjaminpaige benjaminpaige approved these changes

@hannasage hannasage Awaiting requested review from hannasage

@Walesango2 Walesango2 Awaiting requested review from Walesango2

Assignees
No one assigned
Labels
released on @val
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdial89f @benjaminpaige @13bfrancis