feat(breadcrumbs): Refactor breadcrumbs to remove path filter #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannasage
commented
Nov 6, 2023
| user?.isCms && | ||
| user.user?.["custom:cms-roles"].includes(UserRoles.HELPDESK) | ||
| ? "cmsStatus.keyword" | ||
| : "stateStatus.keyword", |
There was a problem hiding this comment.
Ooops! Lemme remove this, this was leftover from helping Wale lol
13bfrancis
reviewed
Nov 6, 2023
13bfrancis
reviewed
Nov 6, 2023
| return ( | ||
| <SimplePageContainer> | ||
| <BreadCrumbs options={BREAD_CRUMB_CONFIG_NEW_SUBMISSION} /> | ||
| <BreadCrumbs options={NEW_SUBMISSION_CRUMBS(location.pathname)} /> |
There was a problem hiding this comment.
Love this little function here to build out the option. I'm always a big fan of declarative code
13bfrancis
approved these changes
Nov 7, 2023
|
🎉 This PR is included in version 1.5.0-val.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Previously, breadcrumbs filtered out the options array with the following line:
That means any crumb where the route wasn't present in the current path would be filtered out and not shown. This PR removes that filter and leaves the crumb config array in the hands of the developer since not every breadcrumb needs to be directly related to the path. This PR also refactors the config for the New Submission breadcrumb options so that it can be built dynamic via the current path.
Linked Issues to Close
None
Approach
A config's available items are explicitly the responsibility of the config. The component no longer will filter any out, it'll only sort them based on order.
Assorted Notes/Considerations/Learning
None