feat(issue and respond to RAIs): Implement post sub actions for issuing and responding to RAIs #197

mdial89f · 2023-11-16T17:09:15Z

Purpose

This changeset adds support for Issuing and RAI and Responding to an RAI.

Linked Issues to Close

https://qmacbis.atlassian.net/browse/OY2-26062
https://qmacbis.atlassian.net/browse/OY2-25561
https://qmacbis.atlassian.net/browse/OY2-26268
https://qmacbis.atlassian.net/browse/OY2-26267

Approach

Issuing and responding to an RAI have very similiar forms at the moment, although their separation for now is wise, I think.
The ability to issue or respond to an RAI is guarded by the getPackageActions api logic, which is used both on the frontend and then checked again on the backend.
rai data in the 'main' index is now stored under an 'rais' key. the structure within that key is shaped as

export interface RaiData {
  [key: number]: {
    requestedDate?: string;
    responseDate?: string;
    withdrawnDate?: string;
    response?: {
      additionalInformation: string;
      submitterName: string | null;
      submitterEmail: string | null;
      attachments: any[] | null; 
    };
    request?: {
      additionalInformation: string;
      submitterName: string | null;
      submitterEmail: string | null;
      attachments: any[] | null;
    };
  };
}

So each RAI object, identified and keyed off its requested timestamp, contains top level timestamps as gotten from Seatool, as well as response and request metadata, as gotten from the mako kafka topic.

Using this structure, along with turning indexing 'off' for the rais field, we're able to easily marry the seatool data about rais to the mako counterpart, and make that data available to the app.

Currently, we're showing RAI Activity at the bottom of the page. Theres a row for each RAI thats occurred. They're enumerated in increasing order, and it shows the latest status of that RAI.

Other things fixed:

Hiding the action type column for spa/chips.
Hiding submission source for spa/chips/waivers
Fixing the 'delete' functionality when a record is deleted in seatool.

Assorted Notes/Considerations/Learning

We will undoubtedly change how we show and present this RAI data. Screens and finer detail is being worked out, but this should be a good starting point. I think this PR shows what data is available and how its organized. So, I submit this as a place to start.

hannasage · 2023-11-17T16:44:20Z

src/packages/shared-utils/is-cms-write-user.ts

+import { CMS_WRITE_ROLES, CognitoUserAttributes } from "../shared-types";
+
+export const isCmsWriteUser = (user: CognitoUserAttributes) => {
+  const userRoles = user["custom:cms-roles"];


Can we group this with the other CMS user utility. I can imagine we'll need more of these down the line for auth checks, and a file per function gets out excessive when they're this little. Looks like we grouped the RAI helpers 👍🏼 seems like a good pattern to continue here as user-helpers

yep, done. very much agree with this, was too scared to break pattern earlier
thanks

hannasage · 2023-11-17T16:50:36Z

src/services/data/handlers/sink.ts

  )[] = [];

+  const rawArr: any[] = [];


rawArr is a pretty vague name, and the any[] type doesn't help. Can you better declare this based on its purpose?

i actually didn't mean to keep this in... was a dev debug helper thing. removed, thanks

hannasage · 2023-11-17T16:51:46Z

src/services/ui/src/components/Opensearch/Filtering/index.tsx

@@ -47,7 +47,7 @@ export const OsFiltering: FC<{
          },
          {
            name: "State",
-            transform: (data) => data.state,
+            transform: (data) => data.state ?? "",


Is this a case where we should be using the empty field display? (i.e. "-- --")

yep, thanks

hannasage · 2023-11-17T16:57:24Z

src/services/ui/src/pages/actions/RespondToRai.tsx

+      RaiResponseTransform["rais"][number]["response"]["attachments"]
+    > = [];
+
+    const presignedUrls: Promise<PreSignedURL>[] = uploadKeys


This is work we've done before for the Medicaid form. We should be refactoring this into reusable code rather than copy/pasting code across files.

yea i agree. i think once we've got medicaid end to end done, we can pull out everything that works for reuse. I'm shy abot doing that now.
Defer to later

I fail to see how "getting medicaid end to end done" will affect the way we handle uploading files, tho...especially when that form has been done and we're now in the part of engineering where we can reuse lots of that work we put in? I think this "build it fast, then clean up later" mentality is fine when you're bouncing from product to product doing quick work, but this is a product we have to support and we're not doing a good job of setting ourselves up for that by copy-pasting identical blocks everywhere in our code. We really need to build in a practice to our team where we discuss approaches to these kinds of things so we can save ourselves time and mess.

hannasage · 2023-11-17T16:58:17Z

src/services/ui/src/pages/actions/RespondToRai.tsx

+              for each of the attachment types on the{" "}
+              {
+                <Link
+                  to="/faq/#medicaid-spa-attachments"


Linking to medicaid spa attachments won't help :P

yep, thanks. updated

hannasage · 2023-11-17T16:59:42Z

src/services/ui/src/pages/actions/RespondToRai.tsx

+            </Alert>
+          ) : null}
+          {form.formState.isSubmitting ? (
+            <div className="p-4">


Not sure you need the extra markup here. You should be able to just do {form.formState.isSubmitting && <LoadingSpinner />}, no div and no else condition.

spot on, good find. done, thanks.

hannasage · 2023-11-17T17:01:50Z

src/services/ui/src/pages/actions/RespondToRai.tsx

+            />
+            <Modal
+              open={errorModalIsOpen}
+              onAccept={() => {


We don't have a consistent Error handling pattern but we need one. I don't think this is the way, honestly. The copy will inevitably send droves of users to the helpdesk when we could probably just communicate there was a network issue or that our servers are at fault.

ya i looked, we have an api error ticket, to make a more global approach. defer to then.

hannasage · 2023-11-17T17:03:22Z

src/services/ui/src/pages/dashboard/Lists/spas/consts.tsx

@@ -41,6 +41,7 @@ export const TABLE_COLUMNS = (props?: {
  {
    field: "actionType.keyword",
    label: "Action Type",
+    visible: false,


Do we want to keep the row but hide it, or legitimately remove the rows. I don't believe action type or source are available columns in current OneMAC spec.

keep but hide

github-actions · 2024-02-15T00:12:41Z

🎉 This PR is included in version 1.5.0-val.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mdial89f and others added 30 commits November 7, 2023 05:35

Show issue rai for all records for cms user

5917321

basic routing setup

76081ac

base

9943c17

form work

9970b9c

nothing

e164a3e

basic func

f2d7ab6

sink

c045e36

Merge branch 'master' into issuerai

1a92952

yut

8b520a5

brians lib

b4bbbeb

fix thing

d8c4af4

bringing in brian

43eaf99

add functionality for sinking actions to opensearch

00eff86

remove action-type from schema (not needed)

053441f

fix breadcrumb type error

0afb047

finished up flow (fingers crossed)

2f6e865

fix typescript error for tombstone

9976017

get the last item in array

a90e233

update with timestamp from frontend

f195a1f

update status

0e1919c

move to using a transaction with rollback etc

cc18f29

Merge branch 'issuerai' into idm

f840a61

REVERTME push raw onemac records to other index

e3a2575

fix thing

15ae9ad

fix for attachments ullish

297db86

increase timeout

639c859

stop custom compaction for onemac

99f0fe0

fix deletes

665fc5e

udpates per brian

f17f645

pass action on enable thing

37cf5c1

mdial89f added 15 commits November 16, 2023 16:01

Merge branch 'master' into engine

e819786

drop these cases

8f4a6d1

fixes

e48d5ca

Let all pending statuses issue an rai

c367670

response fixes

29624ab

yut

e195c6c

modals for issue

e00e3b2

modals for response

3a93f46

remove dev thing

d4241b4

i think this looks bad and is redundant

dcc0996

language

c073dd9

11

b8bf36a

error handling and fixes

a269b9a

fix 13

73e4796

add package details consistently

14097df

hannasage reviewed Nov 17, 2023

View reviewed changes

mdial89f added 10 commits November 17, 2023 16:58

put a sentence back

647ba66

language

65cad99

fix up role logic.. user helper could probably go for some refactoring

86566a7

Update text at bottom

02dbf8e

fix broken disable bit

6d08e42

use blank value

ac24da2

remove

97452b0

update faq links

c26db03

drop unneeded markup

edea356

little bit of cleanup

69e80a8

mdial89f requested a review from hannasage November 18, 2023 14:07

mdial89f merged commit 03472d1 into master Nov 20, 2023
25 checks passed

github-actions bot added the released on @val label Feb 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(issue and respond to RAIs): Implement post sub actions for issuing and responding to RAIs #197

feat(issue and respond to RAIs): Implement post sub actions for issuing and responding to RAIs #197

mdial89f commented Nov 16, 2023 •

edited

Loading

hannasage Nov 17, 2023

mdial89f Nov 17, 2023

hannasage Nov 17, 2023

mdial89f Nov 17, 2023

hannasage Nov 17, 2023

mdial89f Nov 17, 2023

hannasage Nov 17, 2023

mdial89f Nov 17, 2023

hannasage Nov 21, 2023

hannasage Nov 17, 2023

mdial89f Nov 17, 2023

hannasage Nov 17, 2023

mdial89f Nov 17, 2023

hannasage Nov 17, 2023

mdial89f Nov 17, 2023

mdial89f Nov 17, 2023

hannasage Nov 17, 2023

mdial89f Nov 17, 2023

github-actions bot commented Feb 15, 2024

feat(issue and respond to RAIs): Implement post sub actions for issuing and responding to RAIs #197

feat(issue and respond to RAIs): Implement post sub actions for issuing and responding to RAIs #197

Conversation

mdial89f commented Nov 16, 2023 • edited Loading

Purpose

Linked Issues to Close

Approach

Assorted Notes/Considerations/Learning

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 15, 2024

mdial89f commented Nov 16, 2023 •

edited

Loading