Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(initial submission): Enable CHIP SPA submissions on /submit endpoint #247

Merged
merged 5 commits into from
Dec 13, 2023

Conversation

hannasage
Copy link

@hannasage hannasage commented Dec 8, 2023

Purpose

Adds CHIP SPAs to the eligible submission authorities.

Linked Issues to Close

https://qmacbis.atlassian.net/browse/OY2-26094

Approach

We allow specific authorities declared in an array. We added CHIP SPA to the array.

Assorted Notes/Considerations/Learning

All functionality for Medicaid SPA submissions was reusable: the dbo insert, the kafka message, and the sink from seatool to mako.

Screen Shot 2023-12-08 at 2 09 55 PM

@hannasage hannasage self-assigned this Dec 8, 2023
@hannasage hannasage marked this pull request as ready for review December 8, 2023 19:19
Copy link
Contributor

@mdial89f mdial89f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinhaube These look ok. I see you're working on the frontend 25748... I'd like to hold off merging this to master, and have Padma review this and 25748 on one branch together. We may be missing a piece or two, and it will be easier to test when there's a frontend to drive it.

@hannasage
Copy link
Author

hannasage commented Dec 11, 2023

@mdial89f The point of this PR is to enable that to happen without lumping back-end changes into that PR. I did a crude approach to duplicating the form to test, and I already have the front-end changes in another branch being worked. Padma and I already discussed a testing plan. Thank you.

@hannasage hannasage requested a review from mdial89f December 11, 2023 15:28
@mdial89f
Copy link
Contributor

Hey @kevinhaube i approved but then noticed the merges to master caused a conflict. It was pretty simple so I updated here. You still have my approval, over to you to squash merge.

@hannasage hannasage merged commit 3bbd2ed into master Dec 13, 2023
14 checks passed
@hannasage hannasage deleted the oy2-26094 branch December 13, 2023 15:10
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants