Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Google Analytics): add appropriate Google Analytics tags to the various endpoints #301

Merged
merged 15 commits into from
Jan 16, 2024

Conversation

kristin-at-theta
Copy link
Collaborator

@kristin-at-theta kristin-at-theta commented Jan 8, 2024

Purpose

To add Google Analytics tags to the application.

Linked Issues to Close

none

Approach

Used a vite plugin to add the tags. Google Analytics uses url/tag pairs, so multiple tags are needed for this application because of the many endpoints. There is some minor disabling/enabling that should protect PROD from collecting test data.

Assorted Notes/Considerations/Learning

Because of the url/tag dependency... won't really know if this actually works until we get it all the way up 😬

@kristin-at-theta kristin-at-theta marked this pull request as ready for review January 11, 2024 18:34
Copy link
Collaborator

@benjaminpaige benjaminpaige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great.

@kristin-at-theta kristin-at-theta marked this pull request as draft January 16, 2024 15:42
@kristin-at-theta kristin-at-theta changed the title Add ga feat(Google Analytics): add appropriate Google Analytics tags to the various endpoints Jan 16, 2024
@kristin-at-theta kristin-at-theta marked this pull request as ready for review January 16, 2024 18:51
Copy link
Contributor

@mdial89f mdial89f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good title, good stuff, we will see if the master branch gets its tag correctly.
Let's try it!
don't forget to squash

@kristin-at-theta kristin-at-theta merged commit 685f680 into master Jan 16, 2024
18 checks passed
@pkim-gswell pkim-gswell added the type: FEAT Submit new features label Jan 24, 2024
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants