-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Google Analytics): add appropriate Google Analytics tags to the various endpoints #301
Conversation
… know they will change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great.
proposed change to keep ids out of src
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good title, good stuff, we will see if the master branch gets its tag correctly.
Let's try it!
don't forget to squash
🎉 This PR is included in version 1.5.0-val.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Purpose
To add Google Analytics tags to the application.
Linked Issues to Close
none
Approach
Used a vite plugin to add the tags. Google Analytics uses url/tag pairs, so multiple tags are needed for this application because of the many endpoints. There is some minor disabling/enabling that should protect PROD from collecting test data.
Assorted Notes/Considerations/Learning
Because of the url/tag dependency... won't really know if this actually works until we get it all the way up 😬