Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(substatus and 2nd clock): Correct rai resp withdraw enabled substatus logic, as well as 2nd clock display #345

Merged
merged 12 commits into from
Jan 25, 2024

Conversation

mdial89f
Copy link
Contributor

@mdial89f mdial89f commented Jan 24, 2024

Purpose

This changeset fixes some bugs with the conditional display of sub status and 2nd clock on records.

Linked Issues to Close

Closes https://qmacbis.atlassian.net/browse/OY2-26539
Closes https://qmacbis.atlassian.net/browse/OY2-26876

Approach

This PR tackles two somewhat interrelated bugs:

RAI Response Withdraw Enabled:

Amongst the RAI lifecycle operations for medicaid, chip, and waiver packages, there is a concept of RAI Response Withdraw Enabled. It supports the workflow of a CMS user allowing (enabling) a state user to withdraw a previously submitted response, as well as rescinding that allowance. This is reflected in the package's opensearch document as a boolean, raiWithdrawEnabled (true/false).
This PR modifies slightly how and when this package configuration is displayed to different types of users.

  • All users will see the 'Formal RAI Response Withdraw Enabled' within the Status column on the dashboard for all record types.
  • All users will see the 'Formal RAI Response Withdraw Enabled' substatus on the Details page when viewing any record.
  • All users will see '(Formal RAI Response Withdraw Enabled)' appended to the status in the status column of any export.
    The code uses the raiWithdrawEnabled boolean set in opensearch to perform this logic on the frontend.
Screen Shot 2024-01-24 at 1 39 28 PM Screen Shot 2024-01-24 at 1 40 16 PM

2nd Clock display

There's a concept of '2nd Clock' for Medicaid and Waiver packages (note that CHIP is excluded). A record is considered 'in 2nd clock' when it

  • is in any pending state
  • has an RAI
  • the RAI has been responded to
    The code accommodates this logic in the sink, setting a 'secondClock' boolean in the main index's documents. The frontend then conditionally displays '2nd Clock' on the status card for CMS users only.
Screen Shot 2024-01-24 at 1 38 57 PM

Assorted Notes/Considerations/Learning

None

@mdial89f mdial89f marked this pull request as draft January 24, 2024 18:29
@mdial89f mdial89f added the bug label Jan 24, 2024
@mdial89f mdial89f self-assigned this Jan 24, 2024
@mdial89f mdial89f marked this pull request as ready for review January 24, 2024 18:40
Copy link
Contributor

@pkim-gswell pkim-gswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iapprove

@pkim-gswell pkim-gswell added type: FIX Submit bug fixes status: READY PR is ready for review and removed bug labels Jan 24, 2024
@mdial89f
Copy link
Contributor Author

@pkim-gswell love the new tags

@mdial89f mdial89f changed the title fix(substatus and 2nd clock): Correct rai resp withdraw enabled substatus logic, as well as 2nd clock login fix(substatus and 2nd clock): Correct rai resp withdraw enabled substatus logic, as well as 2nd clock display Jan 24, 2024
@mdial89f mdial89f merged commit d80d5b2 into master Jan 25, 2024
16 checks passed
@mdial89f mdial89f deleted the get-stricty branch January 26, 2024 17:32
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @val status: READY PR is ready for review type: FIX Submit bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants