-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(substatus and 2nd clock): Correct rai resp withdraw enabled substatus logic, as well as 2nd clock display #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkim-gswell
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/packages/shared-types/opensearch/main/transforms/seatool.ts
Outdated
Show resolved
Hide resolved
This reverts commit a157972.
pkim-gswell
added
type: FIX
Submit bug fixes
status: READY
PR is ready for review
and removed
bug
labels
Jan 24, 2024
@pkim-gswell love the new tags |
mdial89f
changed the title
fix(substatus and 2nd clock): Correct rai resp withdraw enabled substatus logic, as well as 2nd clock login
fix(substatus and 2nd clock): Correct rai resp withdraw enabled substatus logic, as well as 2nd clock display
Jan 24, 2024
🎉 This PR is included in version 1.5.0-val.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This changeset fixes some bugs with the conditional display of sub status and 2nd clock on records.
Linked Issues to Close
Closes https://qmacbis.atlassian.net/browse/OY2-26539
Closes https://qmacbis.atlassian.net/browse/OY2-26876
Approach
This PR tackles two somewhat interrelated bugs:
RAI Response Withdraw Enabled:
Amongst the RAI lifecycle operations for medicaid, chip, and waiver packages, there is a concept of RAI Response Withdraw Enabled. It supports the workflow of a CMS user allowing (enabling) a state user to withdraw a previously submitted response, as well as rescinding that allowance. This is reflected in the package's opensearch document as a boolean, raiWithdrawEnabled (true/false).
This PR modifies slightly how and when this package configuration is displayed to different types of users.
The code uses the raiWithdrawEnabled boolean set in opensearch to perform this logic on the frontend.
2nd Clock display
There's a concept of '2nd Clock' for Medicaid and Waiver packages (note that CHIP is excluded). A record is considered 'in 2nd clock' when it
The code accommodates this logic in the sink, setting a 'secondClock' boolean in the main index's documents. The frontend then conditionally displays '2nd Clock' on the status card for CMS users only.
Assorted Notes/Considerations/Learning
None