feat(init waiver): init waiver submission forms #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run different queries based on the authority (waiver, spa, chip, etc)
this should set one of the dropdown fields in seatool which is mapped to the type table in the db
the type and sub-type queries will be important in PI 3 when we have more understanding
mdial89f
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
@13bfrancis I stepped through the AC of the tickets in question and made some edits. None of them were functional... most just copy/paste of exact language required.
Approving
mdial89f
added
status: TESTING
hannasage
reviewed
Feb 5, 2024
| ? rules.filter((r) => r.check(checks, user)).map((r) => r.action) | ||
| : []; | ||
| return [ | ||
| ...((checks.isWaiver || checks.isSpa) |
There was a problem hiding this comment.
This can be done inside the ActionRules for closer control. We should move away from conditionally outputting outside of those rules
There was a problem hiding this comment.
Also unsure why we're spreading an array inside an array
src/services/ui/src/pages/form/waiver/capitated/capitated-1915-b-waiver-renewal.tsx
Outdated
Show resolved
Hide resolved
| formData | ||
| ) => { | ||
| try { | ||
| // AK-0260.R04.02 |
src/services/ui/src/pages/form/waiver/contracting/contracting-1915-b-waiver-renewal.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
87
to
116
| export const zAmendmentOriginalWaiverNumberSchema = z | ||
| .string() | ||
| .regex( | ||
| /^[A-Z]{2}-\d{4,5}.R\d{2}.\d{2}$/, | ||
| "The 1915(b) Waiver Amendment Number must be in the format of SS-####.R##.## or SS-#####.R##.##. For amendments, the last two digits start with ‘01’ and ascends." | ||
| ) | ||
| .refine((value) => isAuthorizedState(value), { | ||
| message: | ||
| "You can only submit for a state you have access to. If you need to add another state, visit your IDM user profile to request access.", | ||
| }) | ||
| // This should already exist. | ||
| .refine(async (value) => !(await idIsUnique(value)), { | ||
| message: | ||
| "According to our records, this 1915(b) Waiver Number does not yet exist. Please check the 1915(b) Waiver Amendment Number and try entering it again.", | ||
| }); | ||
| export const zRenewalOriginalWaiverNumberSchema = z | ||
| .string() | ||
| .regex( | ||
| /^[A-Z]{2}-\d{4,5}.R\d{2}.\d{2}$/, | ||
| "The 1915(b) Waiver Renewal Number must be in the format of SS-####.R##.## or SS-#####.R##.##." | ||
| ) | ||
| .refine((value) => isAuthorizedState(value), { | ||
| message: | ||
| "You can only submit for a state you have access to. If you need to add another state, visit your IDM user profile to request access.", | ||
| }) | ||
| // This should already exist | ||
| .refine(async (value) => !(await idIsUnique(value)), { | ||
| message: | ||
| "According to our records, this 1915(b) Waiver Number does not yet exist. Please check the 1915(b) Waiver Amendment Number and try entering it again.", | ||
| }); |
There was a problem hiding this comment.
Am I missing the need for this redundancy?
daniel-belcher
approved these changes
Feb 5, 2024
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.5.0-val.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This will be adding the ability to submit waiver forms for both capitated and contracting. This will be important as it will unlock the ability to start work on app-k's and continue to figure out what we need to do to evolve these forms.
Linked Issues to Close
Closes https://qmacbis.atlassian.net/browse/OY2-27135
Approach
A minimalistic and minimal abstraction approach was taken. After much discussion with the group, we don't know yet enough about where this is gonna head to make any decisions. The important thing in this current state was to get something out there that we can continue to evolve on.
Assorted Notes/Considerations/Learning