Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(add general UI): add general UI validation for Sub-doc #888

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

zerogravit1
Copy link
Collaborator

@zerogravit1 zerogravit1 commented Dec 3, 2024

Purpose

Implement a general UI framework and increase coverage of Sub Doc e2e

Linked Issues to Close

none

Approach

Builds e2e structure for supporting forms

Assorted Notes/Considerations/Learning

Still needs a deeper dive into cards and how test-dataids can cascade down from a parent element to a child element.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 71.07% 5701 / 8021
🔵 Statements 70.48% 6030 / 8555
🔵 Functions 64.9% 1707 / 2630
🔵 Branches 40.01% 1016 / 2539
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react-app/src/components/ActionForm/ActionFormAttachments.tsx 100% 100% 100% 100%
react-app/src/components/ActionForm/actionForm.components.tsx 100% 92.85% 100% 100%
react-app/src/components/ActionForm/index.tsx 93.75% 91.3% 88.88% 93.54% 263-264
react-app/src/components/Cards/SectionCard.tsx 100% 100% 100% 100%
react-app/src/components/Form/content/ContentWrappers.tsx 88.88% 28.57% 50% 88.88% 70-84
Generated in workflow #746 for commit b969fc0 by the Vitest Coverage Report Action

Copy link
Collaborator

@13bfrancis 13bfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@zerogravit1 zerogravit1 changed the title feat: add general UI validation for Sub-doc feat(add general UI): add general UI validation for Sub-doc Dec 3, 2024
@zerogravit1 zerogravit1 merged commit e33e62c into main Dec 6, 2024
32 of 33 checks passed
@zerogravit1 zerogravit1 deleted the subsequent-documnent-qa-2 branch December 6, 2024 18:55
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.98 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants