Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): PDF Links in VAL #908

Merged
merged 2 commits into from
Dec 9, 2024
Merged

fix(ui): PDF Links in VAL #908

merged 2 commits into from
Dec 9, 2024

Conversation

RanyeM
Copy link
Collaborator

@RanyeM RanyeM commented Dec 9, 2024

🎫 Linked Ticket

#887
https://jiraent.cms.gov/browse/OY2-29929

💬 Description / Notes

Add links to the FAQ page to the corresponding MMDL template. (reference google drive folder)
Links should be ordered and worded like in the HCD figma
When clicked, the pdf template should open in a new tab

🛠 Changes

Given I am a Mako user, When I navigate to the FAQ page, Then I should be able to click the MMDL templates and view the template in a new tab.

Dev Note: The document names use the same title as the question/header on the FAQ page. For example, if the section header is "ABP 1: Alternative Benefit Plan Populations", then document on the google drive named "IG_ABP1_AlternativeBenefitPlanPopulations.doc" should be attached to that FAQ link.

Google Folder with MMDL Templates: https://drive.google.com/drive/folders/1C7LtmhwMoqJnfqfdOKUkhbgZ6W7uSgtt?usp=drive_link

Figma (reference "Final" tab): https://www.figma.com/design/TJcaOKbbiLOaMMV3MQmczT/MMDL-PDFs-into-OneMAC?node-id=329-9126&node-type=canvas&t=SCgkJLxfLZL69cZh-0

@RanyeM RanyeM self-assigned this Dec 9, 2024
@RanyeM RanyeM changed the title fix VAL issues Fixed PDF Links VAL issues Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 71.09% 5719 / 8044
🔵 Statements 70.52% 6049 / 8577
🔵 Functions 65.05% 1720 / 2644
🔵 Branches 40.02% 1017 / 2541
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react-app/src/features/faq/content/abpTemplate.tsx 100% 100% 100% 100%
react-app/src/features/faq/content/mpcGuides.ts 100% 100% 100% 100%
react-app/src/features/faq/content/mpcTemplates.ts 100% 100% 100% 100%
react-app/src/features/faq/content/oneMACFAQContent.tsx 100% 100% 100% 100%
Generated in workflow #859 for commit 34c8961 by the Vitest Coverage Report Action

Copy link
Collaborator

@asharonbaltazar asharonbaltazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@RanyeM RanyeM merged commit 49b1935 into main Dec 9, 2024
21 checks passed
@asharonbaltazar asharonbaltazar deleted the pdf-links branch December 10, 2024 17:11
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.98 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants