Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Appendix K Form, Instructions, and Modal Design Updates #936

Merged
merged 15 commits into from
Dec 18, 2024

Conversation

tbolt
Copy link
Collaborator

@tbolt tbolt commented Dec 13, 2024

🎫 Linked Ticket

Closes OY2-31581

💬 Description / Notes

  • Updates "Appendix K" -> "1915(c) Appendix K" in various locations with App-K related forms. Including instructions and modal.
  • See original ticket for full list of changes

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 74.66% 6042 / 8092
🔵 Statements 73.94% 6368 / 8612
🔵 Functions 68.41% 1802 / 2634
🔵 Branches 42.75% 1177 / 2753
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react-app/src/features/forms/post-submission/respond-to-rai/index.tsx 70% 50% 50% 70% 18, 48, 76
react-app/src/features/forms/post-submission/upload-subsequent-documents/index.tsx 72.72% 53.84% 88.88% 72.72% 22, 64, 72-83, 146
react-app/src/features/forms/post-submission/withdraw-package/index.tsx 38.46% 0% 33.33% 38.46% 8-44, 96, 144
react-app/src/features/forms/post-submission/withdraw-rai/index.tsx 100% 33.33% 100% 100%
Generated in workflow #1109 for commit 1f28219 by the Vitest Coverage Report Action

@tbolt tbolt temporarily deployed to app-k-package-updates December 13, 2024 19:05 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates December 13, 2024 19:05 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates December 13, 2024 19:07 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates December 13, 2024 19:07 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates-kibana December 13, 2024 19:07 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates-app December 13, 2024 19:07 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates December 13, 2024 19:07 — with GitHub Actions Inactive
@tbolt tbolt marked this pull request as ready for review December 16, 2024 14:07
Copy link
Collaborator

@asharonbaltazar asharonbaltazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nits, but do you think a function that formats 1915(c) to 1915(c) Appendix K would save some repetition?

@tbolt tbolt temporarily deployed to app-k-package-updates December 16, 2024 14:47 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates December 16, 2024 14:47 — with GitHub Actions Inactive
@tbolt
Copy link
Collaborator Author

tbolt commented Dec 16, 2024

@asharonbaltazar Updated to address your feedback. For you question on how repetitive that format will be, I don't know. Based on your knowledge do you think it's something we should abstract into a utility or something like that?

@tbolt tbolt temporarily deployed to app-k-package-updates December 16, 2024 14:50 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates December 16, 2024 14:50 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates December 17, 2024 14:15 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates December 17, 2024 14:19 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates December 17, 2024 14:19 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates-kibana December 17, 2024 14:19 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates-app December 17, 2024 14:19 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates December 17, 2024 14:19 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates December 17, 2024 14:26 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates December 17, 2024 14:26 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates December 17, 2024 14:28 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates-kibana December 17, 2024 14:28 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates-app December 17, 2024 14:28 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates December 17, 2024 14:28 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to app-k-package-updates December 17, 2024 14:28 — with GitHub Actions Inactive
@tbolt tbolt had a problem deploying to app-k-package-updates December 18, 2024 15:38 — with GitHub Actions Failure
@tbolt tbolt temporarily deployed to app-k-package-updates December 18, 2024 15:38 — with GitHub Actions Inactive
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.98 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asharonbaltazar asharonbaltazar deleted the app-k-package-updates branch January 13, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants