Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Cannot set min/max bitrate at stream start time from frontend #275

Closed
DenisTensorWorks opened this issue Jun 20, 2023 · 3 comments
Closed
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@DenisTensorWorks
Copy link
Collaborator

DenisTensorWorks commented Jun 20, 2023

**UE Version: **
UE 5.2

Problem component
Frontend

Description
Min/MaxBitrate unable to be set from frontend at stream start time, neither it can be configured during stream running.
It does, however, work if the stream is re-started.

Reason being, UE sends its initial settings message which contains the information about min/max bitrate, which overrides what’s set on the frontend before the frontend has a chance to send its URL values.

For context, if the limitations are added to application launch args instead, i.e. -PixelStreamingEncoderMaxBitrate=5000, they work as expected.

Suggested fix is to send this info as a config message.

@DenisTensorWorks DenisTensorWorks added the bug Something isn't working label Jun 20, 2023
@mcottontensor
Copy link
Contributor

This is a tricky one since the config would need to be sent before the stream starts but we have no connection to the endpoint until the webrtc connection is negotiated and streaming.
Perhaps there is something we can put in the SDP.

@github-actions
Copy link
Contributor

Issues go stale after 30 days of inactivity. Please comment or re-open the issue if you are still interested in getting this issue fixed.

@github-actions github-actions bot added the stale label Jul 24, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2023
@DenisTensorWorks DenisTensorWorks added enhancement New feature or request and removed stale labels Aug 22, 2023
@lukehb
Copy link
Contributor

lukehb commented Oct 23, 2023

I do think when we loop round to this, we should consider putting the metadata into the SDP - that actually seems pretty reasonable considering what we are trying to achieve here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Development

No branches or pull requests

3 participants