Make Closure public, moving it to ClosureSerializer #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closure is moved to ClosureSerializer because it's tightly coupled and this makes the connection more obvious. This also renames `Kryo.isClousre` to `isClosure`, assuming that it was not used until now it's ignored regarding binary compatibility. Fixes EsotericSoftware#299, refs EsotericSoftware#215
|
👍 we need this for twitter/chill#252 |
For this test the compiler source/target level for tests must be set to 1.8. This is done via the "java8" profile which is activated if built with java 8+. Java8*Tests are excluded by default from tests compilation, this profile removes this exclude. Because overriding the compiler plugin in the profile did not really work build properties are used. To deactivate the java8 profile (e.g. to compile tests for jdks < 1.8) mvn can be invoked with `-P !java8` (or `-P \!java8` on linux). Refs EsotericSoftware#299
|
@romix WDYT? |
|
No objections from me. |
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closure is moved to ClosureSerializer because they're tightly coupled and this makes the connection more obvious.
This also renames
Kryo.isClousretoisClosure, assuming that it was not used until now it's ignored regarding binary compatibility.A test for closure serialization is added together with the required maven foo for compiler settings.
Fixes #299, refs #215