Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal input not working with ConPTY disabled #3397

Closed
elkondzik opened this issue Feb 1, 2021 · 8 comments
Closed

Terminal input not working with ConPTY disabled #3397

elkondzik opened this issue Feb 1, 2021 · 8 comments

Comments

@elkondzik
Copy link

Version: 1.0.130
Platform: win32 6.1.7601
Plugins: none

Whenever key is pressed in the terminal, app is throwing following exception:

events.js:292 Uncaught Error: This socket has been ended by the other party at Socket.writeAfterFIN [as write] (net.js:456) at WindowsTerminal._doWrite (C:\Users\xxx\AppData\Local\Programs\Terminus\resources\app.asar\node_modules\@terminus-term\node-pty\lib\windowsTerminal.js:114) at WindowsTerminal._defer (C:\Users\xxx\AppData\Local\Programs\Terminus\resources\app.asar\node_modules\@terminus-term\node-pty\lib\windowsTerminal.js:156) at WindowsTerminal._write (C:\Users\xxx\AppData\Local\Programs\Terminus\resources\app.asar\node_modules\@terminus-term\node-pty\lib\windowsTerminal.js:111) at WindowsTerminal.Terminal.write (C:\Users\xxx\AppData\Local\Programs\Terminus\resources\app.asar\node_modules\@terminus-term\node-pty\lib\terminal.js:81) at Session.write (C:\Users\xxx\AppData\Local\Programs\Terminus\resources\builtin-plugins\terminus-terminal\dist\index.js:12988) at TerminalTabComponent.sendInput (C:\Users\xxx\AppData\Local\Programs\Terminus\resources\builtin-plugins\terminus-terminal\dist\index.js:8736) at SafeSubscriber._next (C:\Users\xxx\AppData\Local\Programs\Terminus\resources\builtin-plugins\terminus-terminal\dist\index.js:8964) at SafeSubscriber.__tryOrUnsub (C:\Users\xxx\AppData\Local\Programs\Terminus\resources\app.asar\node_modules\rxjs\internal\Subscriber.js:205) at SafeSubscriber.next (C:\Users\xxx\AppData\Local\Programs\Terminus\resources\app.asar\node_modules\rxjs\internal\Subscriber.js:143)
Full_Debug.log

@Eugeny
Copy link
Owner

Eugeny commented Feb 1, 2021

See if enabling ConPTY under Settings -> Shell helps

@Kri-Ol
Copy link

Kri-Ol commented Feb 2, 2021

Same here. Windows 2016 Server (roughly the same as Windows 10 1607), no ConPTY support

@radiaku
Copy link

radiaku commented Feb 2, 2021

Bump up, I got same error. and no conpty support

@elkondzik
Copy link
Author

elkondzik commented Feb 2, 2021

Yes, exactly. No ConPTY property under settings->shell.
Any other suggestions? Or is this bug to be fixed?
Oh, didn't mentioned OS: Windows 7

I also have to add that I tried:

  • Portable version
  • Installable version (installed after removing all previous settings)

It's such a nice and promising terminal app, that I would really appreciate if that one is fixed and I could finally use it :)

@GanapathyRaman
Copy link

See if enabling ConPTY under Settings -> Shell helps

Thanks. Enabling ConPTY works.

@Eugeny
Copy link
Owner

Eugeny commented Feb 6, 2021

Upstream issue: microsoft/node-pty#457

@elkondzik
Copy link
Author

elkondzik commented Feb 7, 2021

Changed release from 1.0.130 --> 1.0.132

Nothing has changed regarding keyboard input on Windows 7:

  1. SYSTEM
    • All releases are OK on Windows 10 (i.e. keyboard works in terminal)
    • None of the releases are OK on Windows 7
  2. ConPTY
    • ConPTY option is still not available in 1.0.132 in Settings --> Shell
    • Setting ConPTY as variable to: true/false/enabled/disabled for any release doesn't help
  3. RELEASE
    • It seems that latest release where it works for Windows 7 is 1.0.127

Any plans fixing it in the nearest future? :)

@uluhonolulu
Copy link

Windows Server 2016, no ConPTY version.

In addition to the socket error, I'm seeing this:

C:\Users\asmirnov\AppData\Local\Programs\Terminus\resources\builtin-plugins\terminus-core\dist\index.js:5724 [updater] Error: Can not find Squirrel
    at AutoUpdater.checkForUpdates (electron/js2c/browser_init.js:17:1405)
    at electron/js2c/browser_init.js:225:8560
    at IpcMainImpl.<anonymous> (electron/js2c/browser_init.js:225:4947)
    at IpcMainImpl.emit (events.js:315:20)
    at IpcMainImpl.EventEmitter.emit (domain.js:486:12)
    at Object.<anonymous> (electron/js2c/browser_init.js:161:10389)
    at Object.emit (events.js:315:20)
    at Object.apply [as emit] (domain.js:486:12)
    at Object.n.emit (C:\Users\asmirnov\AppData\Local\Programs\Terminus\resources\app.asar\dist\webpack:\terminus\node_modules\@sentry\electron\dist\main\integrations\electron.js:66:25)

Hope that helps!

P.S. Thank you for this wonderful program! I started to love command line after I started using it!

@Eugeny Eugeny changed the title Keyboard does not work at all in the Terminal Terminal input not working with ConPTY disabled Feb 13, 2021
@Eugeny Eugeny closed this as completed in 707d077 Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants