Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connext/rest-api-client#98 follow-ups #1927

Open
raladev opened this issue Oct 8, 2020 · 0 comments
Open

connext/rest-api-client#98 follow-ups #1927

raladev opened this issue Oct 8, 2020 · 0 comments
Labels
connext enhancement New feature or request P2 mid priority

Comments

@raladev
Copy link
Contributor

raladev commented Oct 8, 2020

Should be done after connext/rest-api-client#98 merging:

  1. Throw correct err message if user places order with amount bigger then max collateral amount (nobalancechecks=false)
  2. use indra node balance as a max buy tradinglimit if order coll is disabled (nobalancechecks=true)
  3. Change behavior of max flag for buy/sell command - feat: adding new flag to trade all possible quantity for buy/sell #1922 (comment)
@raladev raladev added enhancement New feature or request connext labels Oct 8, 2020
@kilrau kilrau added the P2 mid priority label Oct 8, 2020
@sangaman sangaman self-assigned this Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connext enhancement New feature or request P2 mid priority
Projects
None yet
Development

No branches or pull requests

3 participants