Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder: Support null values in StyxObjectStore.compute #544

Closed
mikkokar opened this issue Nov 29, 2019 · 1 comment
Closed

Placeholder: Support null values in StyxObjectStore.compute #544

mikkokar opened this issue Nov 29, 2019 · 1 comment
Labels
P3 Backlog

Comments

@mikkokar
Copy link
Contributor

A TODO in HealthCheckMonitoringService.kt:

    // The ifPresent is not ideal, but compute() does not allow the computation to return null. So we can't preserve
     // a state where the object does not exist using compute alone. But even with ifPresent, as we are open to
     // the object disappearing between the ifPresent and the compute, which would again lead to the compute creating
     // a new object when we don't want it to. But at least this will happen much less frequently.
     db.get(name).ifPresent {
@bestokes bestokes added the P3 Backlog label Feb 5, 2020
@bestokes
Copy link

Fixed in PR #629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Backlog
Projects
None yet
Development

No branches or pull requests

2 participants