From f5a6e4da411ee030f835ef7c43bf773b3cfec4db Mon Sep 17 00:00:00 2001 From: ahmedGaber93 Date: Wed, 24 May 2023 08:48:14 +0200 Subject: [PATCH 1/2] update QRCode logo propType --- src/components/QRCode/index.js | 4 ++-- src/components/QRShare/propTypes.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/components/QRCode/index.js b/src/components/QRCode/index.js index 41686f7c8502..0cbde99d8c2e 100644 --- a/src/components/QRCode/index.js +++ b/src/components/QRCode/index.js @@ -10,9 +10,9 @@ const propTypes = { url: PropTypes.string.isRequired, /** * The logo which will be displayed in the middle of the QR code. - * Follows `ImageSourcePropType` from react-native. + * Follows ImageProps href from react-native-svg that used by react-native-qrcode-svg. */ - logo: PropTypes.oneOfType([PropTypes.shape({uri: PropTypes.string}), PropTypes.number]), + logo: PropTypes.oneOfType([PropTypes.shape({uri: PropTypes.string}), PropTypes.number, PropTypes.string]), /** * The QRCode size */ diff --git a/src/components/QRShare/propTypes.js b/src/components/QRShare/propTypes.js index bcb55f99ea69..4b53ce512597 100644 --- a/src/components/QRShare/propTypes.js +++ b/src/components/QRShare/propTypes.js @@ -16,7 +16,7 @@ const qrSharePropTypes = { /** * The logo which will be display in the middle of the QR code */ - logo: PropTypes.string, + logo: PropTypes.oneOfType([PropTypes.shape({uri: PropTypes.string}), PropTypes.number, PropTypes.string]), }; const defaultProps = { From 720730c58efba0fee258cb0f7136ddba3e1c5cb2 Mon Sep 17 00:00:00 2001 From: ahmedGaber93 Date: Fri, 26 May 2023 01:03:21 +0200 Subject: [PATCH 2/2] update QRCode logo propType --- src/components/QRCode/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/QRCode/index.js b/src/components/QRCode/index.js index 0cbde99d8c2e..06503d5987e7 100644 --- a/src/components/QRCode/index.js +++ b/src/components/QRCode/index.js @@ -10,7 +10,7 @@ const propTypes = { url: PropTypes.string.isRequired, /** * The logo which will be displayed in the middle of the QR code. - * Follows ImageProps href from react-native-svg that used by react-native-qrcode-svg. + * Follows ImageProps href from react-native-svg that is used by react-native-qrcode-svg. */ logo: PropTypes.oneOfType([PropTypes.shape({uri: PropTypes.string}), PropTypes.number, PropTypes.string]), /**