Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat- OpenApp does not return an Onyx update object for key: fakePolicyID with value: null after refreshing the page #10104

Closed
kavimuru opened this issue Jul 26, 2022 · 5 comments
Assignees

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue was found when executing #9906

Action Performed:

  1. Open your browser console
  2. Sign in to the App
  3. Verify that OpenApp returns an Onyx update object, i.e. key: policy_<POLICY_ID> for each policy in your test account
  4. Disable internet connect and enable it again
  5. Verify that ReconnectApp returns an Onyx update object, i.e. key: policy_<POLICY_ID> for each policy in your test account
  6. Refresh the App and verify that OpenApp returns an Onyx update object for key: fakePolicyID with value: null

Expected Result:

OpenApp should returns an Onyx update object for key: fakePolicyID with value: null

Actual Result:

OpenApp isn't returns an Onyx update object for key: fakePolicyID with value: null

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: v1.1.86-0

Reproducible in staging?: Y

Reproducible in production?: Y

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:
Bug5662949_Screen_Shot_2022-07-25_at_8 34 20_PM
Bug5662949_Screen_Shot_2022-07-25_at_8 36 40_PM

Bug5662949_null.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause internal team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2022

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@luacmartins
Copy link
Contributor

Hmm this is likely to the fact that we pass an empty list to the server here. We should probably fix that and only send non-empty lists. @marcochavezf do you want to take this one?

@marcochavezf
Copy link
Contributor

Sure! I will take this one, thanks for pointing out where we should check the empty list!

@melvin-bot melvin-bot bot added the Overdue label Aug 1, 2022
@marcochavezf
Copy link
Contributor

Working on this one today

@melvin-bot melvin-bot bot removed the Overdue label Aug 1, 2022
@marcochavezf
Copy link
Contributor

Ah the fakePolicyID with value null only appears when it's tested locally by following step 7 of #9906. This works as expected when fakePolicyID is hardcoded from the local server as stated in the instructions:

Screen Shot 2022-08-02 at 14 59 01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants