Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace - Spanish - Decimal separator comma is missing on the keyboard and dot is non functional on keyboard #10108

Closed
kavimuru opened this issue Jul 26, 2022 · 28 comments
Assignees

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing #9800

Action Performed:

  1. Launch App and login with Expensify account
  2. Change language to Spanish
  3. Open Settings > Workspace > Reimburse expenses

Expected Result:

Verify that it's possible to enter a decimal number with three digits after the comma into Rate input

Actual Result:

Impossible to enter a decimal number into Rate input since comma is not available in the keyboard. The dot is non functional on the keyboard.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web

Version Number: 1.1.86-1

Reproducible in staging?: y

Reproducible in production?: y

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Expensify/Expensify Issue URL:

Issue reported by: Applause internal team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2022

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Santhosh-Sellavel
Copy link
Collaborator

I've already found it check here this will be addressed in a followup PR.

@yuwenmemon
Copy link
Contributor

Okay great, assigning to you @Santhosh-Sellavel

@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2022

@Santhosh-Sellavel Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Aug 1, 2022
@Santhosh-Sellavel
Copy link
Collaborator

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Aug 1, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 5, 2022

@Santhosh-Sellavel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Aug 5, 2022
@Santhosh-Sellavel
Copy link
Collaborator

Not overdue discussion going on in slack

@melvin-bot melvin-bot bot removed the Overdue label Aug 5, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 9, 2022

@Santhosh-Sellavel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Aug 9, 2022
@Santhosh-Sellavel
Copy link
Collaborator

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Aug 11, 2022
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added the Overdue label Aug 23, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 23, 2022

@Santhosh-Sellavel 10 days overdue. Is anyone even seeing these? Hello?

@Santhosh-Sellavel
Copy link
Collaborator

PR is live

@melvin-bot melvin-bot bot removed the Overdue label Aug 24, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2022

@Santhosh-Sellavel Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Aug 30, 2022
@Santhosh-Sellavel
Copy link
Collaborator

Not overdue PR is up

@melvin-bot melvin-bot bot removed the Overdue label Aug 30, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 5, 2022

@Santhosh-Sellavel Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Sep 5, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 7, 2022

@Santhosh-Sellavel Still overdue 6 days?! Let's take care of this!

@Santhosh-Sellavel
Copy link
Collaborator

PR is up already

@melvin-bot melvin-bot bot removed the Overdue label Sep 7, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 13, 2022

@Santhosh-Sellavel Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Sep 13, 2022
@Santhosh-Sellavel
Copy link
Collaborator

PR is yet to be merged.

@melvin-bot melvin-bot bot removed the Overdue label Sep 14, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 20, 2022

@Santhosh-Sellavel Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Sep 20, 2022
@Santhosh-Sellavel
Copy link
Collaborator

Pr deployed

@melvin-bot melvin-bot bot removed the Overdue label Sep 20, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 26, 2022

@Santhosh-Sellavel Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Sep 26, 2022
@Santhosh-Sellavel
Copy link
Collaborator

PR is deployed

@melvin-bot melvin-bot bot removed the Overdue label Sep 26, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 30, 2022

@Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Sep 30, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2022

@Santhosh-Sellavel Still overdue 6 days?! Let's take care of this!

@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2022

@Santhosh-Sellavel 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@Santhosh-Sellavel
Copy link
Collaborator

Fixed now, and should be closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants