Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2022-08-04] [$250] App crashes when navigating back from bank account page - reported by @Puneet-here #10133

Closed
mountiny opened this issue Jul 27, 2022 · 25 comments
Closed

[HOLD for payment 2022-08-04] [$250] App crashes when navigating back from bank account page - reported by @Puneet-here #10133

mountiny opened this issue Jul 27, 2022 · 25 comments
Assignees
@neil-marcellini @stitesExpensify @kadiealexander @Puneet-here
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.

Comments

@mountiny
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

  1. Go to settings
  2. Click on any workspace
  3. Click bank account > connect manually
  4. Press back arrow

Expected Result:

The site shouldn't crash

Actual Result:

The site crashes

Workaround:

None

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

https://expensify.slack.com/files/U037WGYT199/F03RBB7DB4L/screen_recording_2022-07-27_at_10.32.07_pm.mov

Version Number: v1.1.86-4
Reproducible in staging?: yes
Reproducible in production?: no
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @Puneet-here
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1658941553744969

View all open jobs on GitHub
@mountiny mountiny added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor Daily KSv2 Improvement Item broken or needs improvement. labels Jul 27, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 27, 2022

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@mountiny
Copy link
Contributor Author

Added External Label, since this deploy blocker was reported by a contributor 🙌

@OSBotify OSBotify mentioned this issue Jul 27, 2022
Closed
92 tasks
@github-actions github-actions bot removed the Daily KSv2 label Jul 27, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 27, 2022

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mountiny
Copy link
Contributor Author

mountiny commented Jul 27, 2022 •
edited
Loading

@Puneet-here shared an error from console:
image

@neil-marcellini neil-marcellini self-assigned this Jul 27, 2022
@stitesExpensify
Copy link
Contributor

@nkuoch it looks like this is related to your PR here https://github.com/Expensify/App/pull/9423/files

@mountiny
Copy link
Contributor Author

I think Nathalie is and will be OOO for a while (based on looking into a calendar)

@stitesExpensify
Copy link
Contributor

NP, i'm looking into it right now. I'm unable to reproduce though.

@neil-marcellini
Copy link
Contributor

I'm also unable to reproduce on Web dev staging, but I can reproduce it on staging.

@stitesExpensify
Copy link
Contributor

Based on that error my guess was this line but like Neil said, it's working correctly on dev.

@stitesExpensify
Copy link
Contributor

Confirmed on staging that that line is the problem, still unsure why it isn't working there but is working on dev.

I think the fix might just be removing this from that line and calling the function directly

@neil-marcellini
Copy link
Contributor

Totally, may I put up a quick PR for that?

@stitesExpensify
Copy link
Contributor

Go for it. Feel free to tag me as the reviewer.

No promises on it working though, just a guess haha

@neil-marcellini
Copy link
Contributor

Awesome thanks. The error message calls out that line specifically so I think it's very likely the problem.

@neil-marcellini neil-marcellini mentioned this issue Jul 27, 2022
Merged
93 tasks
@melvin-bot melvin-bot bot closed this as completed Jul 27, 2022
@Puneet-here
Copy link
Contributor

Is this eligible for the reporting?

@mountiny mountiny removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jul 27, 2022
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 28, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 28, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 28, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 28, 2022

Current assignees @neil-marcellini and @stitesExpensify are eligible for the Exported assigner, not assigning anyone new.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 28, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 28, 2022

📣 @Puneet-here You have been assigned to this job by @laurenreidexpensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@laurenreidexpensify laurenreidexpensify added Help Wanted Apply this label when an issue is open to proposals by contributors and removed Help Wanted Apply this label when an issue is open to proposals by contributors labels Jul 28, 2022
@Puneet-here
Copy link
Contributor

Applied, thank you.

@mountiny mountiny added the Awaiting Payment Auto-added when associated PR is deployed to production label Jul 28, 2022
@laurenreidexpensify laurenreidexpensify removed the External Added to denote the issue can be worked on by a contributor label Aug 2, 2022
@laurenreidexpensify laurenreidexpensify removed their assignment Aug 2, 2022
@laurenreidexpensify laurenreidexpensify added the External Added to denote the issue can be worked on by a contributor label Aug 2, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 2, 2022

Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 2, 2022
@laurenreidexpensify
Copy link
Contributor

@kadiealexander 👋 I'm OOO from tomorrow so reassigning for payment. TLDR is that @Puneet-here reported a critical bug that we expedited for a fix so it didn't get a chance to go through the normal flow with C+ etc as Brandon and Neil fixed it internally. Assuming there's no regression, this is all good to pay on 4 august - job in Upwork here https://www.upwork.com/ab/applicants/1552649042546278400/job-details. Thanks!

@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Aug 2, 2022
@mountiny mountiny changed the title [$250] Hold for Payment 4 August - App crashes when navigating back from bank account page - reported by @Puneet-here [HOLD for payment 2022-08-04] [$250] App crashes when navigating back from bank account page - reported by @Puneet-here Aug 2, 2022
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 4, 2022
@kadiealexander
Copy link
Contributor

Reporting bonus paid! Thanks for your help @Puneet-here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neil-marcellini neil-marcellini

@stitesExpensify stitesExpensify

@kadiealexander kadiealexander

@Puneet-here Puneet-here

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@neil-marcellini @rushatgabhane @mountiny @stitesExpensify @kadiealexander @laurenreidexpensify @OSBotify @Puneet-here