Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing propTypes and defaultPropTypes in a component #10277

Closed
mountiny opened this issue Aug 5, 2022 · 1 comment
Closed

Missing propTypes and defaultPropTypes in a component #10277

mountiny opened this issue Aug 5, 2022 · 1 comment
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@mountiny
Copy link
Contributor

mountiny commented Aug 5, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

Break down in numbered steps

Not sure if these reproduce the issue but the problem definitely exists

  1. Minimize app
  2. let someone message you

Expected Result:

Describe what you think should've happened

Do not crash

Actual Result:

Describe what actually happened

App crashed

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Reload

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

image

Version Number:
Reproducible in staging?: YES
Reproducible in production?: NO
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @AndrewGable
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1659727488178539

View all open jobs on GitHub

@mountiny mountiny added Reviewing Has a PR in review DeployBlockerCash This issue or pull request should block deployment Engineering Daily KSv2 Improvement Item broken or needs improvement. labels Aug 5, 2022
@mountiny mountiny self-assigned this Aug 5, 2022
@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Aug 5, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Aug 5, 2022

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot melvin-bot bot closed this as completed Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

2 participants